Re: [PATCH v2 1/2] drm: rcar-du: Rename DORCR fields to make them 0-based

From: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
To: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
	dri-devel@lists.freedesktop.org
Cc: linux-renesas-soc@vger.kernel.org,
	Kieran Bingham <kieran.bingham@ideasonboard.com>
Subject: Re: [PATCH v2 1/2] drm: rcar-du: Rename DORCR fields to make them 0-based
Date: Thu, 23 Feb 2023 15:51:41 +0200	[thread overview]
Message-ID: <8b32b8da-31c4-e3e8-9777-d72f069cf133@ideasonboard.com> (raw)
In-Reply-To: <20230222234212.5461-2-laurent.pinchart+renesas@ideasonboard.com>

On 23/02/2023 01:42, Laurent Pinchart wrote:
> The DORCR fields were documented in the R-Car H1 datasheet with 1-based
> named, and then got renamed to 0-based in Gen2. The 0-based names are
> used for Gen3 and Gen4, making H1 an outlier. Rename the field macros to
> make them 0-based, in order to increase readability of the code when
> comparing it with the documentation.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
>   drivers/gpu/drm/rcar-du/rcar_du_group.c |  8 ++++----
>   drivers/gpu/drm/rcar-du/rcar_du_regs.h  | 26 ++++++++++++-------------
>   2 files changed, 17 insertions(+), 17 deletions(-)

I thought I already did this... And I see I did, but never sent the 
patch as I couldn't figure the part 2 =).

Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>

  Tomi