From: David Hildenbrand <david@redhat.com>
To: Rebecca Mckeever <remckee0@gmail.com>, outreachy@lists.linux.dev
Cc: Mike Rapoport <rppt@kernel.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/5] memblock tests: update style of comments for memblock_add_*() functions
Date: Mon, 25 Apr 2022 15:38:58 +0200 [thread overview]
Message-ID: <8d80cb56-4216-2d5b-7ab5-8abd60d2871c@redhat.com> (raw)
In-Reply-To: <2ea997e7b5c4737d674a2e5d9288938d557cb0c3.1650633253.git.remckee0@gmail.com>
On 22.04.22 15:32, Rebecca Mckeever wrote:
> Update comments in memblock_add_*() functions to match the style used
> in tests/alloc_*.c by rewording to make the expected outcome more apparent
> and, if more than one memblock is involved, adding a visual of the
> memory blocks.
>
> Signed-off-by: Rebecca Mckeever <remckee0@gmail.com>
Please make sure to not drop Rb/Ack tags and instead carry them along
when you resend patches. This, for example, makes it easier for
reviewers to spot what needs attention and review.
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2022-04-25 13:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-22 13:32 [PATCH v3 0/5] memblock tests: update style of comments Rebecca Mckeever
2022-04-22 13:32 ` [PATCH v3 1/5] memblock tests: update style of comments for memblock_add_*() functions Rebecca Mckeever
2022-04-25 13:38 ` David Hildenbrand [this message]
2022-04-22 13:32 ` [PATCH v3 2/5] memblock tests: update style of comments for memblock_reserve_*() functions Rebecca Mckeever
2022-04-25 13:39 ` David Hildenbrand
2022-04-22 13:33 ` [PATCH v3 3/5] memblock tests: update style of comments for memblock_remove_*() functions Rebecca Mckeever
2022-04-25 13:45 ` David Hildenbrand
2022-04-22 13:33 ` [PATCH v3 4/5] memblock tests: update style of comments for memblock_free_*() functions Rebecca Mckeever
2022-04-22 13:33 ` [PATCH v3 5/5] memblock tests: remove completed TODO item Rebecca Mckeever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d80cb56-4216-2d5b-7ab5-8abd60d2871c@redhat.com \
--to=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=outreachy@lists.linux.dev \
--cc=remckee0@gmail.com \
--cc=rppt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.