From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: Alberto Garcia <berto@igalia.com>, qemu-block@nongnu.org
Cc: kwolf@redhat.com, pavel.dovgaluk@ispras.ru,
qemu-devel@nongnu.org, armbru@redhat.com, stefanha@redhat.com,
pbonzini@redhat.com, mreitz@redhat.com, jsnow@redhat.com,
ari@tuxera.com
Subject: Re: [PATCH v5 14/14] block/qcow2: refactor qcow2_update_options_prepare error paths
Date: Sat, 16 Jan 2021 20:35:02 +0300 [thread overview]
Message-ID: <8e134db4-c82e-928b-9d87-6f09a29a3e98@virtuozzo.com> (raw)
In-Reply-To: <7b459e36-0f18-4668-a53c-aa9e4ce13db7@virtuozzo.com>
12.01.2021 00:17, Vladimir Sementsov-Ogievskiy wrote:
> 11.01.2021 19:08, Alberto Garcia wrote:
>> On Sat 09 Jan 2021 01:58:11 PM CET, Vladimir Sementsov-Ogievskiy wrote:
>>> Keep setting ret close to setting errp and don't merge different error
>>> paths into one. This way it's more obvious that we don't return
>>> error without setting errp.
>>>
>>> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
>>
>> I get the idea, but I feel the code is getting innecessarily verbose.
>>
>> One alternative would be to get rid of all -EINVAL inside the switch
>> block, take advantage of the existing local_err and follow the block
>> with:
>>
>> if (local_err) {
>> error_propagate(errp, local_err);
>> ret = -EINVAL;
>> goto fail;
>> }
>
> Actually in our new paradigm of avoiding error propagation (as well as void functions with errp argument), we should first update read_cache_sizes() to return the value together with setting errp, then we will update read_cache_sizes() call in qcow2_update_options_prepare() and drop local_err from qcow2_update_options_prepare() at all.
Which is actually done during the series, so there is no local_err ;)
>
>>
>> But otherwise your solution is correct, so you can keep it if you
>> prefer:
>>
>> Reviewed-by: Alberto Garcia <berto@igalia.com>
>>
>
> Thanks!
>
>
--
Best regards,
Vladimir
prev parent reply other threads:[~2021-01-16 17:36 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-09 12:57 [PATCH v5 00/14] block: deal with errp: part I Vladimir Sementsov-Ogievskiy
2021-01-09 12:57 ` [PATCH v5 01/14] block: return status from bdrv_append and friends Vladimir Sementsov-Ogievskiy
2021-01-12 17:27 ` Alberto Garcia
2021-01-13 9:59 ` Vladimir Sementsov-Ogievskiy
2021-01-09 12:57 ` [PATCH v5 02/14] block: use return status of bdrv_append() Vladimir Sementsov-Ogievskiy
2021-01-12 17:52 ` Alberto Garcia
2021-01-09 12:58 ` [PATCH v5 03/14] block: check return value of bdrv_open_child and drop error propagation Vladimir Sementsov-Ogievskiy
2021-01-09 12:58 ` [PATCH v5 04/14] blockdev: fix drive_backup_prepare() missed error Vladimir Sementsov-Ogievskiy
2021-01-09 12:58 ` [PATCH v5 05/14] block: drop extra error propagation for bdrv_set_backing_hd Vladimir Sementsov-Ogievskiy
2021-01-09 12:58 ` [PATCH v5 06/14] block/mirror: drop extra error propagation in commit_active_start() Vladimir Sementsov-Ogievskiy
2021-01-09 12:58 ` [PATCH v5 07/14] blockjob: return status from block_job_set_speed() Vladimir Sementsov-Ogievskiy
2021-01-09 12:58 ` [PATCH v5 08/14] block/qcow2: qcow2_get_specific_info(): drop error propagation Vladimir Sementsov-Ogievskiy
2021-01-09 12:58 ` [PATCH v5 09/14] block/qcow2-bitmap: improve qcow2_load_dirty_bitmaps() interface Vladimir Sementsov-Ogievskiy
2021-01-09 12:58 ` [PATCH v5 10/14] block/qcow2-bitmap: return status from qcow2_store_persistent_dirty_bitmaps Vladimir Sementsov-Ogievskiy
2021-01-09 12:58 ` [PATCH v5 11/14] block/qcow2: read_cache_sizes: return status value Vladimir Sementsov-Ogievskiy
2021-01-09 12:58 ` [PATCH v5 12/14] block/qcow2: simplify qcow2_co_invalidate_cache() Vladimir Sementsov-Ogievskiy
2021-01-09 12:58 ` [PATCH v5 13/14] block/qed: bdrv_qed_do_open: deal with errp Vladimir Sementsov-Ogievskiy
2021-01-09 12:58 ` [PATCH v5 14/14] block/qcow2: refactor qcow2_update_options_prepare error paths Vladimir Sementsov-Ogievskiy
2021-01-11 16:08 ` Alberto Garcia
2021-01-11 21:17 ` Vladimir Sementsov-Ogievskiy
2021-01-16 17:35 ` Vladimir Sementsov-Ogievskiy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e134db4-c82e-928b-9d87-6f09a29a3e98@virtuozzo.com \
--to=vsementsov@virtuozzo.com \
--cc=ari@tuxera.com \
--cc=armbru@redhat.com \
--cc=berto@igalia.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pavel.dovgaluk@ispras.ru \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.