From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Julien Grall <julien@xen.org>,
Xen-devel <xen-devel@lists.xenproject.org>
Cc: "Stefano Stabellini" <sstabellini@kernel.org>,
"Volodymyr Babchuk" <Volodymyr_Babchuk@epam.com>,
"Wei Liu" <wl@xen.org>, "Jan Beulich" <JBeulich@suse.com>,
"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [Xen-devel] [PATCH 3/6] xen/domctl: Consolidate hypercall continuation handling at the top level
Date: Mon, 9 Dec 2019 17:20:56 +0000 [thread overview]
Message-ID: <8e13b526-67c1-44ea-edce-bddb814609ed@citrix.com> (raw)
In-Reply-To: <b64d0f83-dd3d-9c5b-8f48-784464bd18ef@xen.org>
On 08/12/2019 12:18, Julien Grall wrote:
> Hi,
>
> On 05/12/2019 22:30, Andrew Cooper wrote:
>> More paths are going start using hypercall continuations. We could
>> add extra
>> calls to hypercall_create_continuation() but it is much easier to handle
>> -ERESTART once at the top level.
>>
>> One complication is XEN_DOMCTL_shadow_op, which for XSA-97 and ABI
>> compatibility in a security fix, turn a DOMCTL continuation into
>> __HYPERVISOR_arch_1. This remains as it was, gaining a comment
>> explaining
>> what is going on.
>>
>> With -ERESTART handling in place, the !domctl_lock_acquire() path can
>> use the
>> normal exit path, instead of opencoding a subset of it locally.
>>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
>> ---
>> CC: Jan Beulich <JBeulich@suse.com>
>> CC: Wei Liu <wl@xen.org>
>> CC: Roger Pau Monné <roger.pau@citrix.com>
>> CC: Stefano Stabellini <sstabellini@kernel.org>
>> CC: Julien Grall <julien@xen.org>
>> CC: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
>> ---
>> xen/arch/x86/domctl.c | 5 ++++-
>> xen/arch/x86/mm/hap/hap.c | 3 +--
>> xen/arch/x86/mm/shadow/common.c | 3 +--
>> xen/common/domctl.c | 19 +++++--------------
>
> You seem to have missed the hypercall_create_continuation() call in
> iommu_do_pci_domctl().
So I have. Fixed.
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-12-09 17:21 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-05 22:30 [Xen-devel] [PATCH 0/6] xen: Support continuations from tasklets Andrew Cooper
2019-12-05 22:30 ` [Xen-devel] [PATCH 1/6] xen/tasklet: Fix return value truncation on arm64 Andrew Cooper
2019-12-08 11:57 ` Julien Grall
2019-12-05 22:30 ` [Xen-devel] [PATCH 2/6] xen/tasklet: Switch data parameter from unsigned long to void * Andrew Cooper
2019-12-08 12:02 ` Julien Grall
2019-12-09 15:28 ` Jan Beulich
2019-12-05 22:30 ` [Xen-devel] [PATCH 3/6] xen/domctl: Consolidate hypercall continuation handling at the top level Andrew Cooper
2019-12-08 12:18 ` Julien Grall
2019-12-09 17:20 ` Andrew Cooper [this message]
2019-12-09 16:19 ` Jan Beulich
2019-12-09 17:29 ` Andrew Cooper
2019-12-10 8:09 ` Jan Beulich
2019-12-05 22:30 ` [Xen-devel] [PATCH 4/6] xen/hypercall: Cope with -ERESTART on more hypercall paths Andrew Cooper
2019-12-08 12:57 ` Julien Grall
2019-12-09 17:37 ` Andrew Cooper
2019-12-11 12:01 ` Julien Grall
2019-12-09 16:25 ` Jan Beulich
2019-12-09 16:29 ` Jan Beulich
2019-12-09 17:43 ` Andrew Cooper
2019-12-10 8:27 ` Jan Beulich
2019-12-05 22:30 ` [Xen-devel] [PATCH 5/6] xen/tasklet: Return -ERESTART from continue_hypercall_on_cpu() Andrew Cooper
2019-12-09 16:52 ` Jan Beulich
2019-12-09 17:49 ` Andrew Cooper
2019-12-10 8:55 ` Jan Beulich
2019-12-10 17:55 ` Andrew Cooper
2019-12-11 7:41 ` Jan Beulich
2019-12-11 9:00 ` Andrew Cooper
2019-12-05 22:30 ` [Xen-devel] [PATCH 6/6] x86/smt: Don't use -EBUSY for smt_up_down_helper() continuations Andrew Cooper
2019-12-10 10:29 ` Jan Beulich
2019-12-06 9:58 ` [Xen-devel] [PATCH 0/6] xen: Support continuations from tasklets Jan Beulich
2019-12-06 10:14 ` Andrew Cooper
2019-12-06 10:18 ` Jan Beulich
2019-12-06 10:22 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e13b526-67c1-44ea-edce-bddb814609ed@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=Volodymyr_Babchuk@epam.com \
--cc=julien@xen.org \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.