Re: xenstored file descriptor leak

From: "Jürgen Groß" <jgross@suse.com>
To: Manuel Bouyer <bouyer@antioche.eu.org>
Cc: xen-devel@lists.xen.org
Subject: Re: xenstored file descriptor leak
Date: Wed, 3 Feb 2021 13:13:53 +0100	[thread overview]
Message-ID: <8e4f159a-9519-3576-8f6b-3800a0e84500@suse.com> (raw)
In-Reply-To: <20210203120336.GA2511@antioche.eu.org>

[-- Attachment #1.1.1: Type: text/plain, Size: 1197 bytes --]

On 03.02.21 13:03, Manuel Bouyer wrote:
> On Wed, Feb 03, 2021 at 12:54:23PM +0100, Jürgen Groß wrote:
>> On 03.02.21 12:48, Manuel Bouyer wrote:
>>> On Wed, Feb 03, 2021 at 09:21:32AM +0100, Jürgen Groß wrote:
>>>> [...]
>>>> This shouldn't happen in case we are closing the socket actively.
>>>>
>>>> In the end we should just do a talloc_free(conn) in
>>>> ignore_connection() if it is a socket based one. This should revert
>>>> the critical modification of the XSA-115 fixes for sockets while
>>>> keeping the desired effect for domain connections.
>>>
>>> Hello
>>> here's an updated patch which works for me. Does anyone see a problem
>>> with it ? If not I will submit it for commit.
>>>
>>
>> Do you really need the first hunk? I would have thought just freeing
>> conn in ignore_connection() is enough.
>>
>> In case you are seeing problems without the first hunk, please say so
>> in a comment added to this hunk in order to avoid it being removed
>> sometimes in the future.
> 
> No I don't need it. From your previous comments I though it was a good idea
> to keep it, but I can remove it if you think it's better.

Yes, please remove it.

Juergen

[-- Attachment #1.1.2: OpenPGP_0xB0DE9DD628BF132F.asc --]
[-- Type: application/pgp-keys, Size: 3135 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]