From: Adrian Hunter <adrian.hunter@intel.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: linux-mmc <linux-mmc@vger.kernel.org>,
linux-block <linux-block@vger.kernel.org>,
Bough Chen <haibo.chen@nxp.com>,
Alex Lemberg <alex.lemberg@sandisk.com>,
Mateusz Nowak <mateusz.nowak@intel.com>,
Yuliy Izrailov <Yuliy.Izrailov@sandisk.com>,
Jaehoon Chung <jh80.chung@samsung.com>,
Dong Aisheng <dongas86@gmail.com>,
Das Asutosh <asutoshd@codeaurora.org>,
Zhangfei Gao <zhangfei.gao@gmail.com>,
Sahitya Tummala <stummala@codeaurora.org>,
Harjani Ritesh <riteshh@codeaurora.org>,
Venu Byravarasu <vbyravarasu@nvidia.com>,
Linus Walleij <linus.walleij@linaro.org>,
Shawn Lin <shawn.lin@rock-chips.com>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH V7 00/10] mmc: Add Command Queue support
Date: Mon, 4 Sep 2017 10:06:25 +0300 [thread overview]
Message-ID: <8e636dd3-89e1-30b2-2c16-626ea33a12fd@intel.com> (raw)
In-Reply-To: <19b101f2-f4ea-8360-ccd2-99a085ecc416@intel.com>
On 01/09/17 16:28, Adrian Hunter wrote:
> On 01/09/17 15:58, Ulf Hansson wrote:
>> + Christoph
>>
>> On 1 September 2017 at 13:42, Adrian Hunter <adrian.hunter@intel.com> wrote:
>>> On 31/08/17 14:56, Adrian Hunter wrote:
>>>> Here is V7 of the hardware command queue patches without the software
>>>> command queue patches, now using blk-mq.
>>>>
>>>> HW CMDQ offers 25% - 50% better random multi-threaded I/O. I see a slight
>>>> 2% drop in sequential read speed but no change to sequential write.
>>>
>>> Any comments?
>>
>> A couple of overall comments, for now.
>>
>> To make sure we don't overlook something when converting to mq, I
>> would prefer that we first convert the existing mmc block code to mq,
>> then we add CMDQ on top.
>
> That doesn't make sense. This patch set is not converting the legacy driver
> to mq therefore it cannot overlook anything for converting to mq.
And then you go silent again.
I can send blk-mq support for legacy requests in a few days if you like, but
I want to hear a better explanation of why you are delaying CQE support.
next prev parent reply other threads:[~2017-09-04 7:13 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-31 11:56 [PATCH V7 00/10] mmc: Add Command Queue support Adrian Hunter
2017-08-31 11:56 ` [PATCH V7 01/10] mmc: core: Introduce host claiming by context Adrian Hunter
2017-08-31 11:56 ` [PATCH V7 02/10] mmc: core: Add support for handling CQE requests Adrian Hunter
2017-08-31 11:56 ` [PATCH V7 03/10] mmc: mmc: Enable Command Queuing Adrian Hunter
2017-08-31 11:56 ` [PATCH V7 04/10] mmc: mmc: Enable CQE's Adrian Hunter
2017-08-31 11:56 ` [PATCH V7 05/10] mmc: block: Use local variables in mmc_blk_data_prep() Adrian Hunter
2017-08-31 11:56 ` [PATCH V7 06/10] mmc: block: Prepare CQE data Adrian Hunter
2017-08-31 11:56 ` [PATCH V7 07/10] mmc: block: Factor out mmc_setup_queue() Adrian Hunter
2017-08-31 11:56 ` [PATCH V7 08/10] mmc: block: Add CQE support Adrian Hunter
2017-08-31 11:56 ` [PATCH V7 09/10] mmc: cqhci: support for command queue enabled host Adrian Hunter
2017-08-31 11:56 ` [PATCH V7 10/10] mmc: sdhci-pci: Add CQHCI support for Intel GLK Adrian Hunter
2017-09-01 11:42 ` [PATCH V7 00/10] mmc: Add Command Queue support Adrian Hunter
2017-09-01 12:58 ` Ulf Hansson
2017-09-01 13:28 ` Adrian Hunter
2017-09-04 7:06 ` Adrian Hunter [this message]
2017-09-04 13:48 ` Ulf Hansson
2017-09-04 18:32 ` Adrian Hunter
2017-09-05 7:24 ` Ulf Hansson
2017-09-05 8:10 ` Adrian Hunter
2017-09-05 17:54 ` Ulf Hansson
2017-09-06 7:20 ` Adrian Hunter
2017-09-06 9:54 ` Ulf Hansson
2017-09-06 10:29 ` Adrian Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e636dd3-89e1-30b2-2c16-626ea33a12fd@intel.com \
--to=adrian.hunter@intel.com \
--cc=Yuliy.Izrailov@sandisk.com \
--cc=alex.lemberg@sandisk.com \
--cc=asutoshd@codeaurora.org \
--cc=dongas86@gmail.com \
--cc=haibo.chen@nxp.com \
--cc=hch@lst.de \
--cc=jh80.chung@samsung.com \
--cc=linus.walleij@linaro.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=mateusz.nowak@intel.com \
--cc=riteshh@codeaurora.org \
--cc=shawn.lin@rock-chips.com \
--cc=stummala@codeaurora.org \
--cc=ulf.hansson@linaro.org \
--cc=vbyravarasu@nvidia.com \
--cc=zhangfei.gao@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.