Re: [PATCH v2 03/22] drm/arc: Use drm_fb_cma_fbdev_init/fini()

From: "Noralf Trønnes" <noralf@tronnes.org>
To: Alexey Brodkin <alexey.brodkin@synopsys.com>,
	"stefan@agner.ch" <stefan@agner.ch>
Cc: "narmstrong@baylibre.com" <narmstrong@baylibre.com>,
	"liviu.dudau@arm.com" <liviu.dudau@arm.com>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	"laurent.pinchart@ideasonboard.com"
	<laurent.pinchart@ideasonboard.com>,
	"marex@denx.de" <marex@denx.de>,
	"boris.brezillon@free-electrons.com"
	<boris.brezillon@free-electrons.com>,
	"z.liuxinliang@hisilicon.com" <z.liuxinliang@hisilicon.com>,
	"kong.kongxinwei@hisilicon.com" <kong.kongxinwei@hisilicon.com>,
	"tomi.valkeinen@ti.com" <tomi.valkeinen@ti.com>,
	"david@lechnology.com" <david@lechnology.com>,
	"puck.chen@hisilicon.com" <puck.chen@hisilicon.com>,
	"jsarha@ti.com" <jsarha@ti.com>,
	"vincent.abriou@st.com" <vincent.abriou@st.com>,
	"alison.wang@freescale.com" <alison.wang@freescale.com>,
	"philippe.cornu@st.com" <philippe.cornu@st.com>,
	"yannick.fertre@st.com" <yannick.fertre@st.com>,
	zourongrong@gmail.c
Subject: Re: [PATCH v2 03/22] drm/arc: Use drm_fb_cma_fbdev_init/fini()
Date: Thu, 27 Sep 2018 14:33:30 +0200	[thread overview]
Message-ID: <8ead73e1-ffc9-369d-17bd-5eab044d5f4b@tronnes.org> (raw)
In-Reply-To: <22ea535c76611810b4370d781037f2fd6872b91c.camel@synopsys.com>

Den 27.09.2018 10.49, skrev Alexey Brodkin:
> Hi Noralf,
>
> On Wed, 2017-11-15 at 15:19 +0100, Noralf Trønnes wrote:
>> Use drm_fb_cma_fbdev_init() and drm_fb_cma_fbdev_fini() which relies on
>> the fact that drm_device holds a pointer to the drm_fb_helper structure.
>> This means that the driver doesn't have to keep track of that.
>> Also use the drm_fb_helper functions directly.
>> Remove unused function prototype arcpgu_fbdev_cma_init().
>>
>> Cc: Alexey Brodkin <abrodkin@synopsys.com>
>> Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
> Similarly to drm/fsl-dcu driver this one never made it upstream.
> I was under impression that entire series will be either accepted or not
> but looks like fixes for separate drivers were pulled via separate trees.
>
> Anyways I like this patch for ARC PGU and may confirm it works
> perfectly fine on top of 4.18.10 so should I pull this into my tree and
> send a pull-request to David or maybe all not yet accepted patches from the
> series may go through the same tree?
>
> -Alexey
>
> And essentially...
> Acked-by: Alexey Brodkin <abrodkin@synopsys.com>
>

It has been superseeded by this patch:

[02/20] drm/arc: Use drm_fbdev_generic_setup()
https://patchwork.freedesktop.org/patch/247862/

I'll reply to the cover letter of this series that it has been superseeded
and why.

Wrt to applying, I only do that if I get an ack from the driver maintainer
or a DRM maintainer for trivial stuff.
Some reply that they have applied/queued the patch in their tree for the
next version.

Noralf.

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel