Re: [Intel-gfx] [PATCH v3 0/5] Asynchronous flip implementation for i915

From: Karthik B S <karthik.b.s@intel.com>
To: Paulo Zanoni <paulo.r.zanoni@intel.com>, intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH v3 0/5] Asynchronous flip implementation for i915
Date: Fri, 29 May 2020 10:43:15 +0530	[thread overview]
Message-ID: <8f6f8164-8370-cb42-6232-67f45b16e3c5@intel.com> (raw)
In-Reply-To: <98b06b60080abbfc178fad96ffbe9757ae0e8d53.camel@intel.com>

On 5/28/2020 11:17 PM, Paulo Zanoni wrote:
> Em qui, 2020-05-28 às 11:09 +0530, Karthik B S escreveu:
>> Without async flip support in the kernel, fullscreen apps where game
>> resolution is equal to the screen resolution, must perform an extra blit
>> per frame prior to flipping.
>>
>> Asynchronous page flips will also boost the FPS of Mesa benchmarks.
>>
>> v2: Few patches have been squashed and patches have been shuffled as
>>      per the reviews on the previous version.
>>
>> v3: Few patches have been squashed and patches have been shuffled as
>>      per the reviews on the previous version.
> 
> Hello
> 
> I asked quite a few questions in the review of v2, but never got any
> replies. I see some things regarding those questions are different in
> v3, but I still would really like to have those answers in direct
> text/email form in order to clarify my understanding of your original
> intent (and also help me understand why things are different in v3).
> Would you mind replying to those emails?

Hi,

Sorry for not doing this earlier. I've now responded to the questions on 
the v2 of this series.

Thank you for all the reviews.

Thanks,
Karthik.B.S
> 
> Thanks,
> Paulo
> 
>>
>> Karthik B S (5):
>>    drm/i915: Add enable/disable flip done and flip done handler
>>    drm/i915: Add support for async flips in I915
>>    drm/i915: Add checks specific to async flips
>>    drm/i915: Do not call drm_crtc_arm_vblank_event in async flips
>>    drm/i915: Enable async flips in i915
>>
>>   drivers/gpu/drm/i915/display/intel_display.c | 71 ++++++++++++++++++++
>>   drivers/gpu/drm/i915/display/intel_sprite.c  |  8 ++-
>>   drivers/gpu/drm/i915/i915_irq.c              | 52 ++++++++++++++
>>   drivers/gpu/drm/i915/i915_irq.h              |  2 +
>>   drivers/gpu/drm/i915/i915_reg.h              |  1 +
>>   5 files changed, 133 insertions(+), 1 deletion(-)
>>
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx