Re: [PATCH] selftests/powerpc: make the test check in eeh-basic.sh posix compliant

From: Frederic Barrat <fbarrat@linux.ibm.com>
To: linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] selftests/powerpc: make the test check in eeh-basic.sh posix compliant
Date: Mon, 4 Jan 2021 10:46:25 +0100	[thread overview]
Message-ID: <8f943d9b-21cd-49b8-fb45-706cb49e4093@linux.ibm.com> (raw)
In-Reply-To: <20201228043459.14281-1-po-hsu.lin@canonical.com>

On 28/12/2020 05:34, Po-Hsu Lin wrote:
> The == operand is a bash extension, thus this will fail on Ubuntu with
> 

Error message is somehow missing. It should read:
"./eeh-basic.sh: 89: test: 2: unexpected operator"

> As the /bin/sh on Ubuntu is pointed to DASH.
> 
> Use -eq to fix this posix compatibility issue.
> 
> Fixes: 996f9e0f93f162 ("selftests/powerpc: Fix eeh-basic.sh exit codes")
> Signed-off-by: Po-Hsu Lin <po-hsu.lin@canonical.com>
> ---

With the above,
Reviewed-by: Frederic Barrat <fbarrat@linux.ibm.com>

Thanks!

>   tools/testing/selftests/powerpc/eeh/eeh-basic.sh | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/powerpc/eeh/eeh-basic.sh b/tools/testing/selftests/powerpc/eeh/eeh-basic.sh
> index 0d783e1..64779f0 100755
> --- a/tools/testing/selftests/powerpc/eeh/eeh-basic.sh
> +++ b/tools/testing/selftests/powerpc/eeh/eeh-basic.sh
> @@ -86,5 +86,5 @@ echo "$failed devices failed to recover ($dev_count tested)"
>   lspci | diff -u $pre_lspci -
>   rm -f $pre_lspci
>   
> -test "$failed" == 0
> +test "$failed" -eq 0
>   exit $?
> 