All of lore.kernel.org
 help / color / mirror / Atom feed
From: Damien Le Moal <dlemoal@kernel.org>
To: John Garry <john.g.garry@oracle.com>,
	Brian King <brking@linux.vnet.ibm.com>,
	martin.petersen@oracle.com
Cc: jejb@linux.ibm.com, linux-scsi@vger.kernel.org, wenxiong@linux.ibm.com
Subject: Re: [PATCH] ipr: Remove SATA support
Date: Thu, 13 Apr 2023 16:49:21 +0900	[thread overview]
Message-ID: <91517007-5a82-4f66-219a-5f1cbedad22f@kernel.org> (raw)
In-Reply-To: <a4f2f204-d14f-ddd4-eeb9-9d132e090de6@oracle.com>

On 4/13/23 16:35, John Garry wrote:
> On 12/04/2023 18:40, Brian King wrote:
>> Linux SATA support in ipr has always been limited to SATA DVDs. The last
>> systems that had the option of including a SATA DVD was Power 8,
>> which have been withdrawn for sometime now, so this support can
>> be removed.
>>
>> Signed-off-by: Brian King<brking@linux.vnet.ibm.com>
>> ---
> 
> Thanks,
> 
> Reviewed-by: John Garry <john.g.garry@oracle.com>
> 
>> -#endif
>>   	.queuecommand = ipr_queuecommand,
>> -	.dma_need_drain = ata_scsi_dma_need_drain,
> 
> This would only be used by libsas now - maybe we should relocate it 
> there (from libata), but prob better not.

Given that with this patch, all ATA drivers will use ->error_handler, there are
lots of cleanups we can do. Let's work on that once this patch is queued !


  reply	other threads:[~2023-04-13  7:50 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-12 17:40 [PATCH] ipr: Remove SATA support Brian King
2023-04-12 22:26 ` Damien Le Moal
2023-04-12 23:56 ` kernel test robot
2023-04-13  2:11 ` kernel test robot
2023-04-13  7:35 ` John Garry
2023-04-13  7:49   ` Damien Le Moal [this message]
2023-04-19  3:10 ` Martin K. Petersen
2023-04-19 13:16   ` Damien Le Moal
2023-04-19 14:17     ` Martin K. Petersen
2023-04-19 18:58       ` Brian King
2023-04-19 19:13         ` Martin K. Petersen
     [not found] <CABa-fKRfE8B2TLVJASB9xQaOXDiYH3YCw0YEEg1UcGu2Le8xWw@mail.gmail.com>
2024-02-29 22:04 ` Damien Le Moal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=91517007-5a82-4f66-219a-5f1cbedad22f@kernel.org \
    --to=dlemoal@kernel.org \
    --cc=brking@linux.vnet.ibm.com \
    --cc=jejb@linux.ibm.com \
    --cc=john.g.garry@oracle.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=wenxiong@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.