From: "William Breathitt Gray" <vilhelm.gray@gmail.com>
To: "linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"bgolaszewski@baylibre.com" <bgolaszewski@baylibre.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>
Cc: "linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>,
"preid@electromag.com.au" <preid@electromag.com.au>,
"yamada.masahiro@socionext.com" <yamada.masahiro@socionext.com>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"linux@rasmusvillemoes.dk" <linux@rasmusvillemoes.dk>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"morten.tiljeset@prevas.dk" <morten.tiljeset@prevas.dk>,
"sean.nyekjaer@prevas.dk" <sean.nyekjaer@prevas.dk>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"lukas@wunner.de" <lukas@wunner.de>,
"geert@linux-m68k.org" <geert@linux-m68k.org>,
William Breathitt Gray <vilhelm.gray@gmail.com>,
"andriy.shevchenko@linux.intel.com"
<andriy.shevchenko@linux.intel.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: [PATCH v17 09/14] gpio: uniphier: Utilize for_each_set_clump8 macro
Date: Wed, 9 Oct 2019 11:27:07 -0400 [thread overview]
Message-ID: <9162.60354440368$1570938803@news.gmane.org> (raw)
In-Reply-To: <cover.1570633189.git.vilhelm.gray@gmail.com>
Replace verbose implementation in set_multiple callback with
for_each_set_clump8 macro to simplify code and improve clarity. An
improvement in this case is that banks that are not masked will now be
skipped.
Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
---
drivers/gpio/gpio-uniphier.c | 16 ++++++----------
1 file changed, 6 insertions(+), 10 deletions(-)
diff --git a/drivers/gpio/gpio-uniphier.c b/drivers/gpio/gpio-uniphier.c
index 93cdcc41e9fb..3e4b15d0231e 100644
--- a/drivers/gpio/gpio-uniphier.c
+++ b/drivers/gpio/gpio-uniphier.c
@@ -15,9 +15,6 @@
#include <linux/spinlock.h>
#include <dt-bindings/gpio/uniphier-gpio.h>
-#define UNIPHIER_GPIO_BANK_MASK \
- GENMASK((UNIPHIER_GPIO_LINES_PER_BANK) - 1, 0)
-
#define UNIPHIER_GPIO_IRQ_MAX_NUM 24
#define UNIPHIER_GPIO_PORT_DATA 0x0 /* data */
@@ -147,15 +144,14 @@ static void uniphier_gpio_set(struct gpio_chip *chip,
static void uniphier_gpio_set_multiple(struct gpio_chip *chip,
unsigned long *mask, unsigned long *bits)
{
- unsigned int bank, shift, bank_mask, bank_bits;
- int i;
+ unsigned long i;
+ unsigned long bank_mask;
+ unsigned long bank;
+ unsigned long bank_bits;
- for (i = 0; i < chip->ngpio; i += UNIPHIER_GPIO_LINES_PER_BANK) {
+ for_each_set_clump8(i, bank_mask, mask, chip->ngpio) {
bank = i / UNIPHIER_GPIO_LINES_PER_BANK;
- shift = i % BITS_PER_LONG;
- bank_mask = (mask[BIT_WORD(i)] >> shift) &
- UNIPHIER_GPIO_BANK_MASK;
- bank_bits = bits[BIT_WORD(i)] >> shift;
+ bank_bits = bitmap_get_value8(bits, i);
uniphier_gpio_bank_write(chip, bank, UNIPHIER_GPIO_PORT_DATA,
bank_mask, bank_bits);
--
2.23.0
next prev parent reply other threads:[~2019-10-09 15:27 UTC|newest]
Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-09 15:26 [PATCH v17 00/14] Introduce the for_each_set_clump8 macro William Breathitt Gray
2019-10-09 15:26 ` William Breathitt Gray
2019-10-09 15:26 ` William Breathitt Gray
2019-10-09 15:26 ` [PATCH v17 01/14] bitops: " William Breathitt Gray
2019-10-09 15:26 ` William Breathitt Gray
2019-10-09 15:26 ` William Breathitt Gray
2019-10-09 16:28 ` Masahiro Yamada
2019-10-09 16:28 ` Masahiro Yamada
2019-10-09 16:28 ` Masahiro Yamada
2019-10-09 17:02 ` William Breathitt Gray
2019-10-09 17:02 ` William Breathitt Gray
2019-10-09 17:09 ` Andy Shevchenko
2019-10-09 17:09 ` Andy Shevchenko
2019-10-09 18:54 ` Geert Uytterhoeven
2019-10-09 18:54 ` Geert Uytterhoeven
2019-10-10 2:28 ` Masahiro Yamada
2019-10-10 2:28 ` Masahiro Yamada
2019-10-10 5:49 ` Andy Shevchenko
2019-10-10 5:49 ` Andy Shevchenko
2019-10-10 5:49 ` Andy Shevchenko
2019-10-10 6:29 ` Geert Uytterhoeven
2019-10-10 6:29 ` Geert Uytterhoeven
2019-10-10 7:41 ` Andy Shevchenko
2019-10-10 7:41 ` Andy Shevchenko
2019-10-10 7:49 ` Geert Uytterhoeven
2019-10-10 7:49 ` Geert Uytterhoeven
2019-10-10 8:07 ` Andy Shevchenko
2019-10-10 8:07 ` Andy Shevchenko
2019-10-10 8:21 ` Geert Uytterhoeven
2019-10-10 8:21 ` Geert Uytterhoeven
2019-10-10 13:12 ` William Breathitt Gray
2019-10-10 13:12 ` William Breathitt Gray
2019-10-09 15:26 ` William Breathitt Gray
2019-10-09 15:27 ` [PATCH v17 02/14] lib/test_bitmap.c: Add for_each_set_clump8 test cases William Breathitt Gray
2019-10-09 15:27 ` William Breathitt Gray
2019-10-09 15:27 ` William Breathitt Gray
2019-10-09 15:27 ` William Breathitt Gray
2019-10-09 15:27 ` William Breathitt Gray
2019-10-09 15:27 ` [PATCH v17 03/14] gpio: 104-dio-48e: Utilize for_each_set_clump8 macro William Breathitt Gray
2019-10-09 15:27 ` William Breathitt Gray
2019-10-09 15:27 ` [PATCH v17 04/14] gpio: 104-idi-48: " William Breathitt Gray
2019-10-09 15:27 ` William Breathitt Gray
2019-10-09 15:27 ` William Breathitt Gray
2019-10-09 15:27 ` William Breathitt Gray
2019-10-09 15:27 ` [PATCH v17 05/14] gpio: gpio-mm: " William Breathitt Gray
2019-10-09 15:27 ` William Breathitt Gray
2019-10-09 15:27 ` [PATCH v17 06/14] gpio: ws16c48: " William Breathitt Gray
2019-10-09 15:27 ` William Breathitt Gray
2019-10-09 15:27 ` [PATCH v17 07/14] gpio: pci-idio-16: " William Breathitt Gray
2019-10-09 15:27 ` William Breathitt Gray
2019-10-09 15:27 ` William Breathitt Gray
2019-10-09 15:27 ` William Breathitt Gray
2019-10-09 15:27 ` [PATCH v17 08/14] gpio: pcie-idio-24: " William Breathitt Gray
2019-10-09 15:27 ` William Breathitt Gray
2019-10-09 15:27 ` William Breathitt Gray
2019-10-09 15:27 ` William Breathitt Gray
2019-10-09 15:27 ` William Breathitt Gray [this message]
2019-10-09 15:27 ` [PATCH v17 09/14] gpio: uniphier: " William Breathitt Gray
2019-10-09 15:27 ` William Breathitt Gray
2019-10-09 15:27 ` William Breathitt Gray
2019-10-09 16:33 ` Masahiro Yamada
2019-10-09 16:33 ` Masahiro Yamada
2019-10-09 16:33 ` Masahiro Yamada
2019-10-09 17:05 ` William Breathitt Gray
2019-10-09 17:05 ` William Breathitt Gray
2019-10-09 15:27 ` [PATCH v17 10/14] gpio: 74x164: Utilize the " William Breathitt Gray
2019-10-09 15:27 ` William Breathitt Gray
2019-10-09 15:27 ` William Breathitt Gray
2019-10-09 15:27 ` William Breathitt Gray
2019-10-09 15:27 ` [PATCH v17 11/14] thermal: intel: intel_soc_dts_iosf: Utilize " William Breathitt Gray
2019-10-09 15:27 ` William Breathitt Gray
2019-10-09 15:27 ` [PATCH v17 12/14] gpio: pisosr: Utilize the " William Breathitt Gray
2019-10-09 15:27 ` William Breathitt Gray
2019-10-09 15:27 ` William Breathitt Gray
2019-10-09 15:27 ` William Breathitt Gray
2019-10-09 15:27 ` [PATCH v17 13/14] gpio: max3191x: " William Breathitt Gray
2019-10-09 15:27 ` William Breathitt Gray
2019-10-09 15:27 ` William Breathitt Gray
2019-10-09 15:27 ` William Breathitt Gray
2019-10-09 15:27 ` [PATCH v17 14/14] gpio: pca953x: " William Breathitt Gray
2019-10-09 15:27 ` William Breathitt Gray
2019-10-09 15:27 ` William Breathitt Gray
2019-10-09 15:27 ` William Breathitt Gray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='9162.60354440368$1570938803@news.gmane.org' \
--to=vilhelm.gray@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bgolaszewski@baylibre.com \
--cc=geert@linux-m68k.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=lukas@wunner.de \
--cc=morten.tiljeset@prevas.dk \
--cc=preid@electromag.com.au \
--cc=sean.nyekjaer@prevas.dk \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.