From: Laurent Vivier <laurent@vivier.eu>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>, qemu-devel@nongnu.org
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Aleksandar Markovic" <aleksandar.m.mail@gmail.com>,
qemu-block@nongnu.org, "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: Re: [PATCH v2] configure: Avoid compiling system tools on user build by default
Date: Mon, 17 Feb 2020 11:04:54 +0100 [thread overview]
Message-ID: <916878d0-18b4-0c47-4645-9fcbd9260891@vivier.eu> (raw)
In-Reply-To: <20200217095955.11140-1-philmd@redhat.com>
Le 17/02/2020 à 10:59, Philippe Mathieu-Daudé a écrit :
> From: Philippe Mathieu-Daudé <f4bug@amsat.org>
>
> User-mode does not need the sytem tools. Do not build them by
> default if user specified --disable-system.
>
> This disables building the following binary on a user-only build:
>
> - elf2dmp
> - qemu-edid
> - qemu-ga
> - qemu-img
> - qemu-io
> - qemu-nbd
> - ivshmem-client
> - ivshmem-server
>
> The qemu-user binary is not affected by this change.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> v2:
> - use simpler if/else statement (therefore not adding Richard R-b)
> - improved description (Aleksandar)
> ---
> configure | 12 +++++++++++-
> 1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 16f94cd96b..d1877a60f5 100755
> --- a/configure
> +++ b/configure
> @@ -455,7 +455,7 @@ guest_agent_ntddscsi="no"
> guest_agent_msi=""
> vss_win32_sdk=""
> win_sdk="no"
> -want_tools="yes"
> +want_tools=""
> libiscsi=""
> libnfs=""
> coroutine=""
> @@ -2199,6 +2199,16 @@ else
> echo big/little test failed
> fi
>
> +##########################################
> +# system tools
> +if test -z "$want_tools"; then
> + if test "$softmmu" = "no"; then
> + want_tools=no
> + else
> + want_tools=yes
> + fi
> +fi
> +
> ##########################################
> # cocoa implies not SDL or GTK
> # (the cocoa UI code currently assumes it is always the active UI
>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
next prev parent reply other threads:[~2020-02-17 10:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-17 9:59 [PATCH v2] configure: Avoid compiling system tools on user build by default Philippe Mathieu-Daudé
2020-02-17 10:04 ` Laurent Vivier [this message]
2020-02-17 12:35 ` Aleksandar Markovic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=916878d0-18b4-0c47-4645-9fcbd9260891@vivier.eu \
--to=laurent@vivier.eu \
--cc=aleksandar.m.mail@gmail.com \
--cc=f4bug@amsat.org \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.