Re: [PATCH 03/13] scsi: qedi: Use QEDI_MODE_NORMAL for error handling

From: Lee Duncan <lduncan@suse.com>
To: Mike Christie <michael.christie@oracle.com>,
	cleech@redhat.com, njavali@marvell.com, mrangankar@marvell.com,
	GR-QLogic-Storage-Upstream@marvell.com,
	martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
	jejb@linux.ibm.com
Subject: Re: [PATCH 03/13] scsi: qedi: Use QEDI_MODE_NORMAL for error handling
Date: Wed, 18 May 2022 09:04:25 -0700	[thread overview]
Message-ID: <91fb1cd4-c8bc-9e08-2b7b-5c78c9f665bc@suse.com> (raw)
In-Reply-To: <20220517222448.25612-4-michael.christie@oracle.com>

On 5/17/22 15:24, Mike Christie wrote:
> When handling errors that lead to host removal use QEDI_MODE_NORMAL. There
> is currently no difference in behavior between NORMAL and SHUTDOWN, but in
> the next patch we will want to know when we are called from the pci_driver
> shutdown callout vs remove/err_handler so we know when userspace is up.
> 
> Signed-off-by: Mike Christie <michael.christie@oracle.com>
> ---
>   drivers/scsi/qedi/qedi_main.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/qedi/qedi_main.c b/drivers/scsi/qedi/qedi_main.c
> index 83ffba7f51da..deebe62e2b41 100644
> --- a/drivers/scsi/qedi/qedi_main.c
> +++ b/drivers/scsi/qedi/qedi_main.c
> @@ -2491,7 +2491,7 @@ static void qedi_board_disable_work(struct work_struct *work)
>   	if (test_and_set_bit(QEDI_IN_SHUTDOWN, &qedi->flags))
>   		return;
>   
> -	__qedi_remove(qedi->pdev, QEDI_MODE_SHUTDOWN);
> +	__qedi_remove(qedi->pdev, QEDI_MODE_NORMAL);
>   }
>   
>   static void qedi_shutdown(struct pci_dev *pdev)

Reviewed-by: Lee Duncan <lduncan@suse.com>