From: Guenter Roeck <linux@roeck-us.net>
To: Chris Packham <chris.packham@alliedtelesis.co.nz>,
antoniu.miclaus@analog.com, alexandre.belloni@bootlin.com,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, jdelvare@suse.com
Cc: linux-rtc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org,
Ibrahim Tilki <Ibrahim.Tilki@analog.com>,
Zeynep Arslanbenzer <Zeynep.Arslanbenzer@analog.com>
Subject: Re: [PATCH v7 1/2] drivers: rtc: add max313xx series rtc driver
Date: Tue, 20 Feb 2024 11:42:18 -0800 [thread overview]
Message-ID: <9281dd01-d20e-4eed-96ae-6aa63c9eb678@roeck-us.net> (raw)
In-Reply-To: <20240219221827.3821415-2-chris.packham@alliedtelesis.co.nz>
On 2/19/24 14:18, Chris Packham wrote:
> From: Ibrahim Tilki <Ibrahim.Tilki@analog.com>
>
> Adding support for Analog Devices MAX313XX series RTCs.
>
Adding -> Add
The subject should really be something like "rtc: max31335: Add support
for additional chips", with details in the patch description.
All those (in my opinion unnecessary) function, data structure,
and variable renames makes it really difficult to review the code.
I don't see the point of that, so please don't expect any further
feedback about the hwmon changes from me.
Thanks,
Guenter
next prev parent reply other threads:[~2024-02-20 19:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-19 22:18 [PATCH v7 0/2] drivers: rtc: add max313xx series rtc driver Chris Packham
2024-02-19 22:18 ` [PATCH v7 1/2] " Chris Packham
2024-02-20 19:42 ` Guenter Roeck [this message]
2024-02-20 20:07 ` Chris Packham
2024-02-20 22:56 ` kernel test robot
2024-02-21 18:04 ` kernel test robot
2024-02-19 22:18 ` [PATCH v7 2/2] dt-bindings: rtc: add max313xx RTCs Chris Packham
2024-02-20 19:21 ` Conor Dooley
2024-02-20 20:11 ` Chris Packham
2024-02-21 20:02 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9281dd01-d20e-4eed-96ae-6aa63c9eb678@roeck-us.net \
--to=linux@roeck-us.net \
--cc=Ibrahim.Tilki@analog.com \
--cc=Zeynep.Arslanbenzer@analog.com \
--cc=alexandre.belloni@bootlin.com \
--cc=antoniu.miclaus@analog.com \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.