From: Tom Rix <trix@redhat.com>
To: Xu Yilun <yilun.xu@intel.com>,
mdf@kernel.org, alex.williamson@redhat.com, kwankhede@nvidia.com,
linux-fpga@vger.kernel.org, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: lgoncalv@redhat.com
Subject: Re: [PATCH 0/3] add VFIO mdev support for DFL devices
Date: Wed, 9 Sep 2020 14:13:59 -0700 [thread overview]
Message-ID: <93200a4f-55a3-0798-3ef2-e0467288d5ba@redhat.com> (raw)
In-Reply-To: <1599549212-24253-1-git-send-email-yilun.xu@intel.com>
This is a new interface, the documentation needs to go
into greater detail. I am particularly interested in the user workflow.
This seems like it would work only for kernel modules.
Please describe both in the documentation.
A sample of a user mode driver would be helpful.
Is putting driver_override using sysfs for each device scalable ? would a list sets of {feature id,files}'s the vfio driver respond to better ?
To be consistent the mdev driver file name should be dfl-vfio-mdev.c
There should be an opt-in flag for drivers being overridden instead of blanket approval of all drivers.
Tom
On 9/8/20 12:13 AM, Xu Yilun wrote:
> These patches depend on the patchset: "Modularization of DFL private
> feature drivers" & "add dfl bus support to MODULE_DEVICE_TABLE()"
>
> https://lore.kernel.org/linux-fpga/1599488581-16386-1-git-send-email-yilun.xu@intel.com/
>
> This patchset provides an VFIO Mdev driver for dfl devices. It makes
> possible for dfl devices be direct accessed from userspace.
>
> Xu Yilun (3):
> fpga: dfl: add driver_override support
> fpga: dfl: VFIO mdev support for DFL devices
> Documentation: fpga: dfl: Add description for VFIO Mdev support
>
> Documentation/ABI/testing/sysfs-bus-dfl | 20 ++
> Documentation/fpga/dfl.rst | 20 ++
> drivers/fpga/Kconfig | 9 +
> drivers/fpga/Makefile | 1 +
> drivers/fpga/dfl.c | 54 ++++-
> drivers/fpga/vfio-mdev-dfl.c | 391 ++++++++++++++++++++++++++++++++
> include/linux/fpga/dfl-bus.h | 2 +
> 7 files changed, 496 insertions(+), 1 deletion(-)
> create mode 100644 drivers/fpga/vfio-mdev-dfl.c
>
next prev parent reply other threads:[~2020-09-09 21:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-08 7:13 [PATCH 0/3] add VFIO mdev support for DFL devices Xu Yilun
2020-09-08 7:13 ` [PATCH 1/3] fpga: dfl: add driver_override support Xu Yilun
2020-09-08 7:13 ` [PATCH 2/3] fpga: dfl: VFIO mdev support for DFL devices Xu Yilun
2020-09-08 7:13 ` [PATCH 3/3] Documentation: fpga: dfl: Add description for VFIO Mdev support Xu Yilun
2020-09-08 21:10 ` Alex Williamson
2020-09-10 8:32 ` Xu Yilun
2020-09-10 15:49 ` Alex Williamson
2020-09-11 6:32 ` Xu Yilun
2020-09-09 21:13 ` Tom Rix [this message]
2020-09-10 9:08 ` [PATCH 0/3] add VFIO mdev support for DFL devices Xu Yilun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=93200a4f-55a3-0798-3ef2-e0467288d5ba@redhat.com \
--to=trix@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=kwankhede@nvidia.com \
--cc=lgoncalv@redhat.com \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mdf@kernel.org \
--cc=yilun.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.