Re: [PATCH] sh: Fix build with CONFIG_UBSAN=y

From: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
To: Kees Cook <keescook@chromium.org>
Cc: Yoshinori Sato <ysato@users.sourceforge.jp>,
	kernel test robot <lkp@intel.com>, Rich Felker <dalias@libc.org>,
	Masahiro Yamada <masahiroy@kernel.org>,
	Nicolas Schier <n.schier@avm.de>,
	 linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org,
	 linux-hardening@vger.kernel.org
Subject: Re: [PATCH] sh: Fix build with CONFIG_UBSAN=y
Date: Wed, 14 Feb 2024 13:52:30 +0100	[thread overview]
Message-ID: <93572a771cb3a0b36a9213f18dd43c034c84cf6d.camel@physik.fu-berlin.de> (raw)
In-Reply-To: <178e0bebb1a85efebce1f504122ee190c068e0c9.camel@physik.fu-berlin.de>

Hi Kees,

On Mon, 2024-02-12 at 19:45 +0100, John Paul Adrian Glaubitz wrote:
> On Mon, 2024-02-12 at 10:26 -0800, Kees Cook wrote:
> > > I just wanted to try reproduce the problem again with the reproducer in [1] as well
> > > as with gcc-13.2.0, but your branch devel/overflow/ubsan-only no longer exists.
> > > 
> > > Can you tell me where to find the patches now?
> > 
> > Sure, they're in -next, but for an -rc2 based tree, see:
> > https://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git/log/?h=for-next/kspp
> 
> OK, thanks. I will give it a try with gcc-13.

I'm still unable to reproduce the error that the kernel test robot reported.

I'm using gcc-13:

glaubitz@node54:/data/home/glaubitz/linux-kees> sh4-linux-gcc
sh4-linux-gcc: fatal error: no input files
compilation terminated.
glaubitz@node54:/data/home/glaubitz/linux-kees> sh4-linux-gcc --version
sh4-linux-gcc (GCC) 13.2.0
Copyright (C) 2023 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

glaubitz@node54:/data/home/glaubitz/linux-kees>

I checked out your tree and the for-next/kspp branch.

Then fetched the config that triggered the bug like this:

$ wget https://download.01.org/0day-ci/archive/20240131/202401310416.s8HLiLnC-lkp@intel.com/config -O .config

Building the kernel with "make -j32 uImage" works fine. No errors except for
some unreleated warnings that still need to be fixed.

Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer
`. `'   Physicist
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913