From: Qian Cai <cai@lca.pw>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: jamessewart@arista.com, logang@deltatee.com,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] pci: fix a -Wtype-limits compilation warning
Date: Wed, 18 Dec 2019 15:08:38 -0500 [thread overview]
Message-ID: <935EF32D-2D9C-46AD-A266-77A259DAE91F@lca.pw> (raw)
In-Reply-To: <20191218182412.GA115305@google.com>
> On Dec 18, 2019, at 1:24 PM, Bjorn Helgaas <helgaas@kernel.org> wrote:
>
> Ugh, that is pretty subtle! Would you mind if we used "unsigned int"
> instead of "u16"? "u16" makes it look like just a mistake -- somebody
> is likely to come along and say devfn only needs "u8" and try to
> change it back. The same might happen with "unsigned int", but at
> least it doesn't look like it was chosen specifically to fit a devfn.
>
> Provisional patch below.
Looks good to me.
prev parent reply other threads:[~2019-12-18 20:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-18 17:00 [PATCH -next] pci: fix a -Wtype-limits compilation warning Qian Cai
2019-12-18 17:22 ` Logan Gunthorpe
2019-12-18 18:24 ` Bjorn Helgaas
2019-12-18 18:31 ` Logan Gunthorpe
2019-12-18 20:08 ` Qian Cai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=935EF32D-2D9C-46AD-A266-77A259DAE91F@lca.pw \
--to=cai@lca.pw \
--cc=helgaas@kernel.org \
--cc=jamessewart@arista.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=logang@deltatee.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.