Re: [PATCH v6 07/10] PCI/RCEC: Add RCiEP's linked RCEC to AER/ERR

From: "Sean V Kelley" <sean.v.kelley@intel.com>
To: "Bjorn Helgaas" <helgaas@kernel.org>
Cc: "Sean V Kelley" <seanvk.dev@oregontracks.org>,
	bhelgaas@google.com, Jonathan.Cameron@huawei.com,
	rafael.j.wysocki@intel.com, ashok.raj@intel.com,
	tony.luck@intel.com, sathyanarayanan.kuppuswamy@intel.com,
	qiuxu.zhuo@intel.com, linux-pci@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 07/10] PCI/RCEC: Add RCiEP's linked RCEC to AER/ERR
Date: Mon, 28 Sep 2020 14:36:00 -0700	[thread overview]
Message-ID: <93B0C872-C440-484A-9908-2D5B974595CD@intel.com> (raw)
In-Reply-To: <20200928014711.GA2475864@bjorn-Precision-5520>

On 27 Sep 2020, at 18:47, Bjorn Helgaas wrote:

> On Sun, Sep 27, 2020 at 06:45:45PM -0500, Bjorn Helgaas wrote:
>> On Tue, Sep 22, 2020 at 02:38:56PM -0700, Sean V Kelley wrote:
>>> From: Qiuxu Zhuo <qiuxu.zhuo@intel.com>
>
>>>  	pci_dbg(dev, "broadcast error_detected message\n");
>>>  	if (state == pci_channel_io_frozen) {
>>> -		pci_bridge_walk(bridge, report_frozen_detected, &status);
>>> +		pci_bridge_walk(bridge, dev, report_frozen_detected, &status);
>>>  		if (type == PCI_EXP_TYPE_RC_END) {
>>> +			/*
>>> +			 * The callback only clears the Root Error Status
>>> +			 * of the RCEC (see aer.c).
>>> +			 */
>>> +			if (bridge)
>>> +				reset_subordinate_devices(bridge);
>>
>> It's unfortunate to add yet another special case in this code, and 
>> I'm
>> not thrilled about the one in aer_root_reset() either.  It's just not
>> obvious why they should be there.  I'm sure if I spent 30 minutes
>> decoding things, it would all make sense.  Guess I'm just griping
>> because I don't have a better suggestion.
>
> I'm sorry, this was unkind of me.  If I don't have a constructive
> idea, there's no reason for me to complain about this.  I apologize.
>
> Bjorn

No worries at all. The unfortunate handling of the Spec for RCEC/RCiEP 
associations and the added needs for native versus non-native is 
frustrating.

Sean