From: Baolu Lu <baolu.lu@linux.intel.com>
To: Ethan Zhao <haifeng.zhao@linux.intel.com>,
iommu@lists.linux-foundation.org, iommu@lists.linux.dev
Cc: baolu.lu@linux.intel.com, Kevin Tian <kevin.tian@intel.com>,
Ashok Raj <ashok.raj@intel.com>, Liu Yi L <yi.l.liu@intel.com>,
Jacob jun Pan <jacob.jun.pan@intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 01/11] iommu/vt-d: debugfs: Remove device_domain_lock usage
Date: Thu, 7 Jul 2022 17:18:04 +0800 [thread overview]
Message-ID: <93f60759-ab1c-7506-161f-2cd07e184dda@linux.intel.com> (raw)
In-Reply-To: <849557ab-9c1b-a2ff-6fc6-6564f38d1187@linux.intel.com>
On 2022/7/7 16:30, Ethan Zhao wrote:
>> -static int show_device_domain_translation(struct device *dev, void *data)
>> +static int __show_device_domain_translation(struct device *dev, void *data)
>> {
>> - struct device_domain_info *info = dev_iommu_priv_get(dev);
>> - struct dmar_domain *domain = info->domain;
>> + struct dmar_domain *domain;
>> struct seq_file *m = data;
>> u64 path[6] = { 0 };
>>
>> + domain = to_dmar_domain(iommu_get_domain_for_dev(dev));
>> if (!domain)
>> return 0;
>>
>> @@ -359,20 +359,39 @@ static int show_device_domain_translation(struct device *dev, void *data)
>> pgtable_walk_level(m, domain->pgd, domain->agaw + 2, 0, path);
>> seq_putc(m, '\n');
>>
>> - return 0;
>> + /* Don't iterate */
>> + return 1;
>> }
>
> Using this return value trick to change the caller behaviour, seems not
> saving
>
> anything, but really cost me a few seconds more to know the
> *incantation* --
>
> 'Don't iterate' :) .
This is defined by iommu_group_for_each_dev(). Return value 0 means
continuing to next one, while non-zero means stopping iteration.
Best regards,
baolu
next prev parent reply other threads:[~2022-07-07 9:18 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-06 2:55 [PATCH v4 00/11] iommu/vt-d: Optimize the use of locks Lu Baolu
2022-07-06 2:55 ` Lu Baolu
2022-07-06 2:55 ` [PATCH v4 01/11] iommu/vt-d: debugfs: Remove device_domain_lock usage Lu Baolu
2022-07-06 2:55 ` Lu Baolu
[not found] ` <849557ab-9c1b-a2ff-6fc6-6564f38d1187@linux.intel.com>
2022-07-07 9:18 ` Baolu Lu [this message]
2022-07-06 2:55 ` [PATCH v4 02/11] iommu/vt-d: Remove clearing translation data in disable_dmar_iommu() Lu Baolu
2022-07-06 2:55 ` Lu Baolu
2022-07-07 3:03 ` Tian, Kevin
2022-07-06 2:55 ` [PATCH v4 03/11] iommu/vt-d: Use pci_get_domain_bus_and_slot() in pgtable_walk() Lu Baolu
2022-07-06 2:55 ` Lu Baolu
2022-07-06 2:55 ` [PATCH v4 04/11] iommu/vt-d: Unnecessary spinlock for root table alloc and free Lu Baolu
2022-07-06 2:55 ` Lu Baolu
2022-07-06 2:55 ` [PATCH v4 05/11] iommu/vt-d: Replace spin_lock_irqsave() with spin_lock() Lu Baolu
2022-07-06 2:55 ` Lu Baolu
2022-07-06 2:55 ` [PATCH v4 06/11] iommu/vt-d: Acquiring lock in domain ID allocation helpers Lu Baolu
2022-07-06 2:55 ` Lu Baolu
2022-07-06 2:55 ` [PATCH v4 07/11] iommu/vt-d: Acquiring lock in pasid manipulation helpers Lu Baolu
2022-07-06 2:55 ` Lu Baolu
2022-07-06 2:55 ` [PATCH v4 08/11] iommu/vt-d: Check device list of domain in domain free path Lu Baolu
2022-07-06 2:55 ` Lu Baolu
2022-07-06 2:55 ` [PATCH v4 09/11] iommu/vt-d: Fold __dmar_remove_one_dev_info() into its caller Lu Baolu
2022-07-06 2:55 ` Lu Baolu
2022-07-06 2:55 ` [PATCH v4 10/11] iommu/vt-d: Use device_domain_lock accurately Lu Baolu
2022-07-06 2:55 ` Lu Baolu
2022-07-06 2:55 ` [PATCH v4 11/11] iommu/vt-d: Convert global spinlock into per domain lock Lu Baolu
2022-07-06 2:55 ` Lu Baolu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=93f60759-ab1c-7506-161f-2cd07e184dda@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=ashok.raj@intel.com \
--cc=haifeng.zhao@linux.intel.com \
--cc=iommu@lists.linux-foundation.org \
--cc=iommu@lists.linux.dev \
--cc=jacob.jun.pan@intel.com \
--cc=kevin.tian@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=yi.l.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.