From: "Elliott, Robert (Persistent Memory)" <elliott@hpe.com>
To: Ming Lei <ming.lei@canonical.com>,
Sagi Grimberg <sagig@dev.mellanox.co.il>
Cc: Jens Axboe <axboe@kernel.dk>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
Christoph Hellwig <hch@infradead.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
"tom.leiming@gmail.com" <tom.leiming@gmail.com>,
Keith Busch <keith.busch@intel.com>,
Kent Overstreet <kent.overstreet@gmail.com>
Subject: RE: [PATCH 1/4] block: bio: introduce helpers to get the 1st and last bvec
Date: Wed, 17 Feb 2016 03:08:16 +0000 [thread overview]
Message-ID: <94D0CD8314A33A4D9D801C0FE68B40295BF96AF7@G4W3202.americas.hpqcorp.net> (raw)
In-Reply-To: <20160215174212.648098b0@tom-T450>
> -----Original Message-----
> From: linux-block-owner@vger.kernel.org [mailto:linux-block-
> owner@vger.kernel.org] On Behalf Of Ming Lei
> Sent: Monday, February 15, 2016 3:42 AM
> Subject: Re: [PATCH 1/4] block: bio: introduce helpers to get the 1st and
> last bvec
...
> diff --git a/include/linux/bio.h b/include/linux/bio.h
...
> static inline void bio_get_last_bvec(struct bio *bio, struct bio_vec *bv)
> {
> - struct bvec_iter iter;
> + struct bvec_iter iter = bio->bi_iter;
> + int idx;
> +
> + bio_advance_iter(bio, &iter, iter.bi_size);
> +
> + WARN_ON(!iter.bi_idx && !iter.bi_bvec_done);
If this ever did trigger, I don't think you'd want it for every bio
with a problem. WARN_ONCE would be safer.
---
Robert Elliott, HPE Persistent Memory
next prev parent reply other threads:[~2016-02-17 3:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-15 7:01 [PATCH 0/4] block: fix bio_will_gap() Ming Lei
2016-02-15 7:01 ` [PATCH 1/4] block: bio: introduce helpers to get the 1st and last bvec Ming Lei
2016-02-15 8:19 ` Sagi Grimberg
2016-02-15 9:42 ` Ming Lei
2016-02-15 20:06 ` Sagi Grimberg
2016-02-16 13:03 ` Ming Lei
2016-02-17 3:08 ` Elliott, Robert (Persistent Memory) [this message]
2016-02-18 4:24 ` Kent Overstreet
2016-02-18 6:16 ` Ming Lei
2016-02-19 1:47 ` Ming Lei
2016-02-15 7:01 ` [PATCH 2/4] block: check virt boundary in bio_will_gap() Ming Lei
2016-02-15 8:22 ` Sagi Grimberg
2016-02-15 10:27 ` Ming Lei
2016-02-15 20:27 ` Sagi Grimberg
2016-02-16 13:05 ` Ming Lei
2016-02-16 13:08 ` Ming Lei
2016-02-15 8:33 ` [PATCH 0/4] block: fix bio_will_gap() Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94D0CD8314A33A4D9D801C0FE68B40295BF96AF7@G4W3202.americas.hpqcorp.net \
--to=elliott@hpe.com \
--cc=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=keith.busch@intel.com \
--cc=kent.overstreet@gmail.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@canonical.com \
--cc=sagig@dev.mellanox.co.il \
--cc=stable@vger.kernel.org \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.