From: Jan Beulich <jbeulich@suse.com>
To: Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Ping: [PATCH 2/2] tools/libs: fix uninstall rule for header files
Date: Thu, 29 Oct 2020 14:47:37 +0100 [thread overview]
Message-ID: <952aa284-9112-a128-db88-4a2e89d8c8ef@suse.com> (raw)
In-Reply-To: <74c629db-0f63-aba0-f294-9668c29b8f70@suse.com>
On 19.10.2020 09:21, Jan Beulich wrote:
> This again was working right only as long as $(LIBHEADER) consisted of
> just one entry.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
While patch 1 has become irrelevant with Juergen's more complete
change, this one is still applicable afaict.
Jan
> ---
> An alternative would be to use $(addprefix ) without any shell loop.
>
> --- a/tools/libs/libs.mk
> +++ b/tools/libs/libs.mk
> @@ -107,7 +107,7 @@ install: build
> .PHONY: uninstall
> uninstall:
> rm -f $(DESTDIR)$(PKG_INSTALLDIR)/$(LIB_FILE_NAME).pc
> - for i in $(LIBHEADER); do rm -f $(DESTDIR)$(includedir)/$(LIBHEADER); done
> + for i in $(LIBHEADER); do rm -f $(DESTDIR)$(includedir)/$$i; done
> rm -f $(DESTDIR)$(libdir)/lib$(LIB_FILE_NAME).so
> rm -f $(DESTDIR)$(libdir)/lib$(LIB_FILE_NAME).so.$(MAJOR)
> rm -f $(DESTDIR)$(libdir)/lib$(LIB_FILE_NAME).so.$(MAJOR).$(MINOR)
>
>
next prev parent reply other threads:[~2020-10-29 13:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-19 7:19 [PATCH 0/2] tools/libs: fix build rules to correctly deal with multiple public headers Jan Beulich
2020-10-19 7:21 ` [PATCH 1/2] tools/libs: fix header symlinking rule Jan Beulich
2020-10-19 7:21 ` [PATCH 2/2] tools/libs: fix uninstall rule for header files Jan Beulich
2020-10-29 13:47 ` Jan Beulich [this message]
2020-10-29 15:24 ` Bertrand Marquis
2020-11-23 13:23 ` Ping²: " Jan Beulich
2020-10-21 12:05 ` [PATCH 0/2] tools/libs: fix build rules to correctly deal with multiple public headers Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=952aa284-9112-a128-db88-4a2e89d8c8ef@suse.com \
--to=jbeulich@suse.com \
--cc=iwj@xenproject.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.