Re: [PATCH 1/1] arch/um: fix forward declaration for vmalloc

From: Richard Weinberger <richard@nod.at>
To: Suren Baghdasaryan <surenb@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	 Stephen Rothwell <sfr@canb.auug.org.au>,
	 kent overstreet <kent.overstreet@linux.dev>,
	 SeongJae Park <sj@kernel.org>,
	 anton ivanov <anton.ivanov@cambridgegreys.com>,
	 Johannes Berg <johannes@sipsolutions.net>,
	 linux-mm <linux-mm@kvack.org>,
	 linux-um <linux-um@lists.infradead.org>,
	 Linux Next Mailing List <linux-next@vger.kernel.org>,
	 linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] arch/um: fix forward declaration for vmalloc
Date: Mon, 22 Apr 2024 22:11:00 +0200 (CEST)	[thread overview]
Message-ID: <95819052.15033.1713816660761.JavaMail.zimbra@nod.at> (raw)
In-Reply-To: <20240326073750.726636-1-surenb@google.com>

----- Ursprüngliche Mail -----
> Von: "Suren Baghdasaryan" <surenb@google.com>
> Betreff: [PATCH 1/1] arch/um: fix forward declaration for vmalloc

> Patch [1] replaced vmalloc() function with a new definition but it did
> not adjust the forward declaration used in UML architecture. Change it
> to act as before.
> Note that this prevents the vmalloc() allocations in __wrap_malloc()
> from being accounted. If accounting here is critical, we will have
> to remove this forward declaration and include vmalloc.h, however
> that would pull in more dependencies and would require introducing more
> architecture-specific headers, like asm/bug.h, asm/rwonce.h, etc.
> This is likely the reason why this forward declaration was introduced
> in the first place.
> 
> [1] https://lore.kernel.org/all/20240321163705.3067592-31-surenb@google.com/
> 
> Fixes: 576477564ede ("mm: vmalloc: enable memory allocation profiling")

This commit id is not in Linus tree.
Do I miss something?

Thanks,
//richard