From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: "Fam Zheng" <fam@euphon.net>, "Thomas Huth" <thuth@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
qemu-devel@nongnu.org,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [PATCH 2/2] gitlab-ci: Test Fedora capstone package
Date: Tue, 26 Jan 2021 13:04:22 +0100 [thread overview]
Message-ID: <95825bc2-0e6b-b9ae-86c3-ac8fa8989559@redhat.com> (raw)
In-Reply-To: <20210126113927.GE3640294@redhat.com>
On 1/26/21 12:39 PM, Daniel P. Berrangé wrote:
> On Tue, Jan 26, 2021 at 12:36:49PM +0100, Philippe Mathieu-Daudé wrote:
>> Test building the 4 targets using the capstone disassembler
>> with the capstone package provided on Fedora.
>>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> ---
>> .gitlab-ci.yml | 7 +++++++
>> 1 file changed, 7 insertions(+)
>>
>> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
>> index de3a3d25b58..913940656de 100644
>> --- a/.gitlab-ci.yml
>> +++ b/.gitlab-ci.yml
>> @@ -493,6 +493,13 @@ build-tci:
>> - QTEST_QEMU_BINARY="./qemu-system-x86_64" ./tests/qtest/pxe-test
>> - QTEST_QEMU_BINARY="./qemu-system-s390x" ./tests/qtest/pxe-test -m slow
>>
>> +build-capstone-distrib:
>> + <<: *native_build_job_definition
>> + variables:
>> + IMAGE: fedora
>> + CONFIGURE_ARGS: --enable-capstone=system --disable-tools --disable-docs
>> + TARGETS: arm-softmmu ppc-softmmu x86_64-linux-user s390x-linux-user
>
> Won't one of the existing jobs using Fedora automatically enable use
> of the system capstone ? I don't think we want to keep adding jobs
> for each new possible configure arg. Instead try to re-use existing
> jobs whereever possible.
I looked but couldn't find one. Eventually the TCI job.
As this is unlikely to fail often, I'll see with Thomas the other
possible policies. Building this every month/release should be enough.
next prev parent reply other threads:[~2021-01-26 12:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-26 11:36 [PATCH 0/2] gitlab-ci: Test Fedora capstone package Philippe Mathieu-Daudé
2021-01-26 11:36 ` [PATCH 1/2] docker: Install libcastone on Fedora Philippe Mathieu-Daudé
2021-01-26 11:36 ` [PATCH 2/2] gitlab-ci: Test Fedora capstone package Philippe Mathieu-Daudé
2021-01-26 11:39 ` Daniel P. Berrangé
2021-01-26 12:04 ` Philippe Mathieu-Daudé [this message]
2021-01-26 12:05 ` [PATCH 0/2] " Thomas Huth
2021-01-26 12:07 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=95825bc2-0e6b-b9ae-86c3-ac8fa8989559@redhat.com \
--to=philmd@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=fam@euphon.net \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.