From: Jeff Mahoney <jeffm@suse.com>
To: Zhao Lei <zhaolei@cn.fujitsu.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 2/3] btrfs-progs: autogen: Make build success in CentOS 6 and 7
Date: Thu, 12 May 2016 10:45:35 -0400 [thread overview]
Message-ID: <9620ebe4-e282-d35f-b99c-981b11957e05@suse.com> (raw)
In-Reply-To: <bbac238126b7efc3ae8307dbc65902634ff15c45.1463049696.git.zhaolei@cn.fujitsu.com>
[-- Attachment #1.1: Type: text/plain, Size: 1618 bytes --]
On 5/12/16 6:42 AM, Zhao Lei wrote:
> btrfs-progs build failed in CentOS 6 and 7:
> #./autogen.sh
> ...
> configure.ac:131: error: possibly undefined macro: PKG_CHECK_VAR
> If this token and others are legitimate, please use m4_pattern_allow.
> See the Autoconf documentation.
> ...
>
> Seems PKG_CHECK_VAR is new in pkgconfig 0.28 (24-Jan-2013):
> http://redmine.audacious-media-player.org/boards/1/topics/736
>
> And the max available version for CentOS 7 in yum-repo and
> rpmfind.net is: pkgconfig-0.27.1-4.el7
> http://rpmfind.net/linux/rpm2html/search.php?query=pkgconfig&submit=Search+...&system=centos&arch=
>
> I updated my pkgconfig to 0.30, but still failed at above error.
> (Maybe it is my setting problem)
>
> To make user in centos 6 and 7 building btrfs-progs without
> more changes, we can avoid using PKG_CHECK_VAR in following
> way found in:
> https://github.com/audacious-media-player/audacious-plugins/commit/f95ab6f939ecf0d9232b3165f9241d2ea9676b9e
>
> Signed-off-by: Zhao Lei <zhaolei@cn.fujitsu.com>
> ---
> configure.ac | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure.ac b/configure.ac
> index 4688bc7..a754990 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -128,7 +128,7 @@ PKG_STATIC(UUID_LIBS_STATIC, [uuid])
> PKG_CHECK_MODULES(ZLIB, [zlib])
> PKG_STATIC(ZLIB_LIBS_STATIC, [zlib])
>
> -PKG_CHECK_VAR([UDEVDIR], [udev], [udevdir])
> +UDEVDIR="$(pkg-config udev --variable=udevdir)"
You need, minimally, AC_SUBST(UDEVDIR) here as well.
-Jeff
--
Jeff Mahoney
SUSE Labs
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 881 bytes --]
next prev parent reply other threads:[~2016-05-12 14:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-12 10:42 [PATCH 1/3] btrfs-progs: autogen: Avoid chdir fail on dirname with blank Zhao Lei
2016-05-12 10:42 ` [PATCH 2/3] btrfs-progs: autogen: Make build success in CentOS 6 and 7 Zhao Lei
2016-05-12 14:45 ` Jeff Mahoney [this message]
2016-05-12 10:42 ` [PATCH 3/3] btrfs-progs: autogen: Don't show success message on fail Zhao Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9620ebe4-e282-d35f-b99c-981b11957e05@suse.com \
--to=jeffm@suse.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=zhaolei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.