Re: [PATCH] hwmon: (dell-smm) Add Dell G5 5505 to DMI table

From: Armin Wolf <W_Armin@gmx.de>
To: tjakobi@math.uni-bielefeld.de, "Pali Rohár" <pali@kernel.org>,
	"Jean Delvare" <jdelvare@suse.com>,
	"Guenter Roeck" <linux@roeck-us.net>
Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hwmon: (dell-smm) Add Dell G5 5505 to DMI table
Date: Sun, 10 Mar 2024 19:26:50 +0100	[thread overview]
Message-ID: <96a938d4-f5c4-4eb9-8406-94102d4b3312@gmx.de> (raw)
In-Reply-To: <20240310174144.859510-1-tjakobi@math.uni-bielefeld.de>

Am 10.03.24 um 18:41 schrieb tjakobi@math.uni-bielefeld.de:

> From: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
>
> Enables reading the speed of the CPU and GPU fan on the G5.
>
> Signed-off-by: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
> ---
>   drivers/hwmon/dell-smm-hwmon.c | 8 ++++++++
>   1 file changed, 8 insertions(+)
>
> diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
> index 44aaf9b9191d..bee9cca2f768 100644
> --- a/drivers/hwmon/dell-smm-hwmon.c
> +++ b/drivers/hwmon/dell-smm-hwmon.c
> @@ -1192,6 +1192,14 @@ static const struct dmi_system_id i8k_dmi_table[] __initconst = {
>   			DMI_MATCH(DMI_PRODUCT_NAME, "XPS"),
>   		},
>   	},
> +	{
> +		.ident = "Dell G5 5505",
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> +			DMI_MATCH(DMI_PRODUCT_FAMILY, "GSeries"),

Hi,

i think you can omit the match of DMI_PRODUCT_FAMILY. Also we already have another G5-series machine
in the DMI list (somewhere at the top). Maybe you can put this entry close to this entry?

Thanks,
Armin Wolf

> +			DMI_MATCH(DMI_PRODUCT_NAME, "G5 5505"),
> +		},
> +	},
>   	{ }
>   };
>