From: Steve Dickson <SteveD@RedHat.com>
To: Yongcheng Yang <yongcheng.yang@gmail.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH] systemd: rpc_pipefs.target use BindsTo= instead of Requires=
Date: Fri, 25 Jan 2019 11:44:14 -0500 [thread overview]
Message-ID: <96be9630-a4bd-0f4c-65ab-4f008134c009@RedHat.com> (raw)
In-Reply-To: <20190125083302.3346-1-yongcheng.yang@gmail.com>
Hello Yongcheng,
On 1/25/19 3:33 AM, Yongcheng Yang wrote:
> The rpc_pipefs.target should enter inactive state if
> var-lib-nfs-rpc_pipefs.mount is stopped. Otherwise,
> services depending rpc_pipefs.target (e.g. nfs-idmapd)
> fail to start after /var/lib/nfs/rpc_pipefs unmounted
>
> Signed-off-by: Yongcheng Yang <yongcheng.yang@gmail.com>
> ---
>
> Reproducing steps:
> $ systemctl stop nfs-idmapd
> $ umount /var/lib/nfs/rpc_pipefs
> $ systemctl start nfs-idmapd
I look at things like this and I think there real
fix here is... Just don't do that! :-)
Now I'm sure the patch works... but... why in the world would anybody
unmount /var/lib/nfs/rpc_pipefs with NFS daemons running?
Unless you are some mad QA person trying to destroy the world! ;-)
steved.
>
> Thanks,
> Yongcheng
>
> systemd/rpc_pipefs.target | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/systemd/rpc_pipefs.target b/systemd/rpc_pipefs.target
> index 01d4d27..5ce3981 100644
> --- a/systemd/rpc_pipefs.target
> +++ b/systemd/rpc_pipefs.target
> @@ -1,3 +1,3 @@
> [Unit]
> -Requires=var-lib-nfs-rpc_pipefs.mount
> +BindsTo=var-lib-nfs-rpc_pipefs.mount
> After=var-lib-nfs-rpc_pipefs.mount
>
prev parent reply other threads:[~2019-01-25 16:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-25 8:33 [PATCH] systemd: rpc_pipefs.target use BindsTo= instead of Requires= Yongcheng Yang
2019-01-25 16:44 ` Steve Dickson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=96be9630-a4bd-0f4c-65ab-4f008134c009@RedHat.com \
--to=steved@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=yongcheng.yang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.