From: Guenter Roeck <linux@roeck-us.net>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Wim Van Sebroeck <wim@linux-watchdog.org>,
linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] watchdog: mtx-1: drop driver owner assignment
Date: Wed, 27 Mar 2024 11:36:46 -0700 [thread overview]
Message-ID: <97006bea-f233-43c9-a038-f2a71ff7c443@roeck-us.net> (raw)
In-Reply-To: <20240327174638.519445-1-krzysztof.kozlowski@linaro.org>
On Wed, Mar 27, 2024 at 06:46:38PM +0100, Krzysztof Kozlowski wrote:
> Core in platform_driver_register() already sets the .owner, so driver
> does not need to.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/mtx-1_wdt.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/watchdog/mtx-1_wdt.c b/drivers/watchdog/mtx-1_wdt.c
> index 152e41ecbb14..06756135033d 100644
> --- a/drivers/watchdog/mtx-1_wdt.c
> +++ b/drivers/watchdog/mtx-1_wdt.c
> @@ -236,7 +236,6 @@ static struct platform_driver mtx1_wdt_driver = {
> .probe = mtx1_wdt_probe,
> .remove_new = mtx1_wdt_remove,
> .driver.name = "mtx1-wdt",
> - .driver.owner = THIS_MODULE,
> };
>
> module_platform_driver(mtx1_wdt_driver);
> --
> 2.34.1
>
prev parent reply other threads:[~2024-03-27 18:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-27 17:46 [PATCH] watchdog: mtx-1: drop driver owner assignment Krzysztof Kozlowski
2024-03-27 18:36 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97006bea-f233-43c9-a038-f2a71ff7c443@roeck-us.net \
--to=linux@roeck-us.net \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.