From: Jan Beulich <jbeulich@suse.com>
To: "Marek Marczykowski-Górecki" <marmarek@invisiblethingslab.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
George Dunlap <George.Dunlap@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>,
Julien Grall <julien.grall@arm.com>,
xen-devel@lists.xenproject.org
Subject: Re: [Xen-devel] [PATCH v4 2/3] xen/efi: optionally call SetVirtualAddressMap()
Date: Fri, 25 Oct 2019 16:27:42 +0200 [thread overview]
Message-ID: <975b7013-d379-4baa-e648-f87776e143f2@suse.com> (raw)
In-Reply-To: <db4793665d03513d06ffd6b3d4a52c8a699ccb0b.1571888583.git-series.marmarek@invisiblethingslab.com>
On 24.10.2019 05:45, Marek Marczykowski-Górecki wrote:
> Some UEFI implementations are not happy about lack of
> SetVirtualAddressMap() call. Likely abuse the address map change
> notification to do things beyond the necessary ConvertPointer() calls.
> Specifically, wihtout the SetVirtualAddressMap() call, some access
> EfiBootServices{Code,Data}, or even totally unmapped areas. Example
> crash of GetVariable() call on Thinkpad W540:
>
> Xen call trace:
> [<0000000000000080>] 0000000000000080
> [<8c2b0398e0000daa>] 8c2b0398e0000daa
>
> Pagetable walk from ffffffff858483a1:
> L4[0x1ff] = 0000000000000000 ffffffffffffffff
>
> ****************************************
> Panic on CPU 0:
> FATAL PAGE FAULT
> [error_code=0002]
> Faulting linear address: ffffffff858483a1
> ****************************************
>
> Fix this by calling SetVirtualAddressMap() runtime service, giving it
> 1:1 map for areas marked as needed during runtime. The address space in
> which EFI runtime services are called is unchanged, but UEFI view of it
> may be.
> Since it's fairly late in Xen 4.13 development cycle, disable it
> by default and hide behind EXPERT.
>
> Signed-off-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-10-25 14:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-24 3:45 [Xen-devel] [PATCH v4 0/3] Optionally call EFI SetVirtualAddressMap() Marek Marczykowski-Górecki
2019-10-24 3:45 ` [Xen-devel] [PATCH v4 1/3] efi: remove old SetVirtualAddressMap() arrangement Marek Marczykowski-Górecki
2019-10-25 14:26 ` Jan Beulich
2019-10-24 3:45 ` [Xen-devel] [PATCH v4 2/3] xen/efi: optionally call SetVirtualAddressMap() Marek Marczykowski-Górecki
2019-10-25 14:27 ` Jan Beulich [this message]
2019-10-24 3:45 ` [Xen-devel] [PATCH v4 3/3] xen/efi: use directmap to access runtime services table Marek Marczykowski-Górecki
2019-10-24 13:11 ` Xia, Hongyan
2019-10-24 13:52 ` marmarek
2019-10-25 14:12 ` Jan Beulich
2019-10-25 14:48 ` [Xen-devel] [PATCH v4 0/3] Optionally call EFI SetVirtualAddressMap() Jürgen Groß
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=975b7013-d379-4baa-e648-f87776e143f2@suse.com \
--to=jbeulich@suse.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=julien.grall@arm.com \
--cc=konrad.wilk@oracle.com \
--cc=marmarek@invisiblethingslab.com \
--cc=sstabellini@kernel.org \
--cc=tim@xen.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.