From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
George Dunlap <george.dunlap@citrix.com>,
Julien Grall <julien@xen.org>,
Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
Subject: [PATCH v4 3/8] serial: drop serial_rx_fn's regs parameter
Date: Tue, 20 Feb 2024 09:53:31 +0100 [thread overview]
Message-ID: <9836c01a-7f9f-4f8e-ba7d-1a7ab7e2e4e1@suse.com> (raw)
In-Reply-To: <e5f62a45-5b68-404d-908e-909f84f87b44@suse.com>
It's simply not needed anymore.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
v2: Re-base over earlier (new/split) patches.
--- a/xen/drivers/char/console.c
+++ b/xen/drivers/char/console.c
@@ -526,7 +526,7 @@ static void switch_serial_input(void)
printk("\n");
}
-static void __serial_rx(char c, struct cpu_user_regs *regs)
+static void __serial_rx(char c)
{
switch ( console_rx )
{
@@ -578,7 +578,7 @@ static void __serial_rx(char c, struct c
#endif
}
-static void cf_check serial_rx(char c, struct cpu_user_regs *regs)
+static void cf_check serial_rx(char c)
{
static int switch_code_count = 0;
@@ -594,10 +594,10 @@ static void cf_check serial_rx(char c, s
}
for ( ; switch_code_count != 0; switch_code_count-- )
- __serial_rx(switch_code, regs);
+ __serial_rx(switch_code);
/* Finally process the just-received character. */
- __serial_rx(c, regs);
+ __serial_rx(c);
}
static void cf_check notify_dom0_con_ring(void *unused)
--- a/xen/drivers/char/serial.c
+++ b/xen/drivers/char/serial.c
@@ -68,7 +68,7 @@ void serial_rx_interrupt(struct serial_p
spin_unlock_irqrestore(&port->rx_lock, flags);
if ( fn != NULL )
- (*fn)(c & 0x7f, regs);
+ fn(c & 0x7f);
}
void serial_tx_interrupt(struct serial_port *port, struct cpu_user_regs *regs)
--- a/xen/drivers/char/xen_pv_console.c
+++ b/xen/drivers/char/xen_pv_console.c
@@ -118,7 +118,7 @@ size_t pv_console_rx(struct cpu_user_reg
{
c = cons_ring->in[MASK_XENCONS_IDX(cons++, cons_ring->in)];
if ( cons_rx_handler )
- cons_rx_handler(c, regs);
+ cons_rx_handler(c);
recv++;
}
--- a/xen/include/xen/serial.h
+++ b/xen/include/xen/serial.h
@@ -15,7 +15,7 @@
struct cpu_user_regs;
/* Register a character-receive hook on the specified COM port. */
-typedef void (*serial_rx_fn)(char c, struct cpu_user_regs *regs);
+typedef void (*serial_rx_fn)(char c);
void serial_set_rx_handler(int handle, serial_rx_fn fn);
/* Number of characters we buffer for a polling receiver. */
next prev parent reply other threads:[~2024-02-20 8:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-20 8:51 [PATCH v4 0/8] limit passing around of cpu_user_regs Jan Beulich
2024-02-20 8:52 ` [PATCH v4 1/8] serial: fake IRQ-regs context in poll handlers Jan Beulich
2024-02-21 23:01 ` Julien Grall
2024-02-20 8:53 ` [PATCH v4 2/8] keyhandler: drop regs parameter from handle_keyregs() Jan Beulich
2024-02-20 8:53 ` Jan Beulich [this message]
2024-02-20 8:53 ` [PATCH v4 4/8] PV-shim: drop pv_console_rx()'s regs parameter Jan Beulich
2024-02-20 8:55 ` [PATCH v4 5/8] serial: drop serial_[rt]x_interrupt()'s " Jan Beulich
2024-02-21 23:02 ` Julien Grall
2024-02-20 8:55 ` [PATCH v4 6/8] IRQ: drop regs parameter from handler functions Jan Beulich
2024-02-20 8:56 ` [PATCH v4 7/8] x86/APIC: drop regs parameter from direct vector " Jan Beulich
2024-02-20 8:57 ` [PATCH v4 8/8] consolidate do_bug_frame() / bug_fn_t Jan Beulich
2024-02-20 8:58 ` [PATCH v4 0/8] limit passing around of cpu_user_regs Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9836c01a-7f9f-4f8e-ba7d-1a7ab7e2e4e1@suse.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@citrix.com \
--cc=julien@xen.org \
--cc=sstabellini@kernel.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.