From: <Tudor.Ambarus@microchip.com>
To: <lukas@wunner.de>, <broonie@kernel.org>
Cc: <linux-spi@vger.kernel.org>, <boris.brezillon@collabora.com>
Subject: Re: [PATCH] spi: atmel-quadspi: Disable clock in probe error path
Date: Mon, 9 Nov 2020 18:56:59 +0000 [thread overview]
Message-ID: <98bb6714-2c99-6373-0f33-b707e970c078@microchip.com> (raw)
In-Reply-To: <8f8dc2815aa97b2378528f08f923bf81e19611f0.1604874488.git.lukas@wunner.de>
On 11/9/20 12:41 AM, Lukas Wunner wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> If the call to of_device_get_match_data() fails on probe of the Atmel
> QuadSPI driver, the clock "aq->pclk" is erroneously not unprepared and
> disabled. Fix it.
>
> Fixes: 2e5c88887358 ("spi: atmel-quadspi: add support for sam9x60 qspi controller")
> Signed-off-by: Lukas Wunner <lukas@wunner.de>
> Cc: <stable@vger.kernel.org> # v5.1+
> Cc: Tudor Ambarus <tudor.ambarus@microchip.com>
> Cc: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com>
Thanks!
> ---
> drivers/spi/atmel-quadspi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/spi/atmel-quadspi.c b/drivers/spi/atmel-quadspi.c
> index 8c009c175f2c..b44521d4a245 100644
> --- a/drivers/spi/atmel-quadspi.c
> +++ b/drivers/spi/atmel-quadspi.c
> @@ -594,7 +594,7 @@ static int atmel_qspi_probe(struct platform_device *pdev)
> if (!aq->caps) {
> dev_err(&pdev->dev, "Could not retrieve QSPI caps\n");
> err = -EINVAL;
> - goto exit;
> + goto disable_pclk;
> }
>
> if (aq->caps->has_qspick) {
> --
> 2.28.0
>
next prev parent reply other threads:[~2020-11-09 18:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-08 22:41 [PATCH] spi: davinci: Fix use-after-free on unbind Lukas Wunner
2020-11-08 22:41 ` [PATCH] spi: st-ssc4: Fix unbalanced pm_runtime_disable() in probe error path Lukas Wunner
2020-11-12 19:39 ` Mark Brown
2020-11-08 22:41 ` [PATCH] spi: synquacer: Disable clock " Lukas Wunner
2020-11-09 14:22 ` Andy Shevchenko
2020-11-09 15:04 ` Lukas Wunner
2020-11-12 19:39 ` Mark Brown
2020-11-08 22:41 ` [PATCH] spi: lpspi: Fix use-after-free on unbind Lukas Wunner
2020-11-12 19:39 ` Mark Brown
2020-11-08 22:41 ` [PATCH] spi: atmel-quadspi: Disable clock in probe error path Lukas Wunner
2020-11-09 18:56 ` Tudor.Ambarus [this message]
2020-11-10 16:03 ` Mark Brown
2020-11-08 22:41 ` [PATCH] spi: pic32: Don't leak DMA channels " Lukas Wunner
2020-11-12 19:39 ` Mark Brown
2020-11-09 7:26 ` [PATCH] spi: davinci: Fix use-after-free on unbind Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98bb6714-2c99-6373-0f33-b707e970c078@microchip.com \
--to=tudor.ambarus@microchip.com \
--cc=boris.brezillon@collabora.com \
--cc=broonie@kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=lukas@wunner.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.