From: "Jürgen Groß" <jgross@suse.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: xen-devel@lists.xenproject.org, x86@kernel.org,
linux-kernel@vger.kernel.org,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH v2 3/5] xen/events: only register debug interrupt for 2-level events
Date: Thu, 22 Oct 2020 15:09:04 +0200 [thread overview]
Message-ID: <98f76c98-00d5-3238-a54f-cce52419160f@suse.com> (raw)
In-Reply-To: <1de24e42-6cb7-4ecb-0eb2-c4a15dc8afc9@suse.com>
On 22.10.20 12:35, Jan Beulich wrote:
> On 22.10.2020 11:49, Juergen Gross wrote:
>> @@ -2080,10 +2080,12 @@ void __init xen_init_IRQ(void)
>> int ret = -EINVAL;
>> evtchn_port_t evtchn;
>>
>> - if (fifo_events)
>> + if (xen_fifo_events)
>> ret = xen_evtchn_fifo_init();
>> - if (ret < 0)
>> + if (ret < 0) {
>> xen_evtchn_2l_init();
>> + xen_fifo_events = false;
>> + }
>
> Another note: While it may not matter right here, maybe better
> first set the variable and the call the function?
I don't think this is really important, TBH.
This code is executed before other cpus are up and we'd have major
other problems in case the sequence would really matter here.
Juergen
next prev parent reply other threads:[~2020-10-22 13:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-22 9:49 [PATCH v2 0/5] xen: event handling cleanup Juergen Gross
2020-10-22 9:49 ` [PATCH v2 1/5] xen: remove no longer used functions Juergen Gross
2020-10-22 9:49 ` [PATCH v2 2/5] xen/events: make struct irq_info private to events_base.c Juergen Gross
2020-10-22 9:49 ` [PATCH v2 3/5] xen/events: only register debug interrupt for 2-level events Juergen Gross
2020-10-22 10:35 ` Jan Beulich
2020-10-22 13:09 ` Jürgen Groß [this message]
2020-10-22 13:17 ` Jan Beulich
2020-10-22 9:49 ` [PATCH v2 4/5] xen/events: unmask a fifo event channel only if it was masked Juergen Gross
2020-10-22 9:49 ` [PATCH v2 5/5] Documentation: add xen.fifo_events kernel parameter description Juergen Gross
2020-10-23 13:37 ` [PATCH v2 0/5] xen: event handling cleanup boris.ostrovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98f76c98-00d5-3238-a54f-cce52419160f@suse.com \
--to=jgross@suse.com \
--cc=boris.ostrovsky@oracle.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=jbeulich@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=sstabellini@kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.