Re: [PATCH v13 4/6] KVM: s390: pv: avoid export before import if possible

From: Janosch Frank <frankja@linux.ibm.com>
To: Claudio Imbrenda <imbrenda@linux.ibm.com>, kvm@vger.kernel.org
Cc: borntraeger@de.ibm.com, thuth@redhat.com, pasic@linux.ibm.com,
	david@redhat.com, linux-s390@vger.kernel.org,
	linux-kernel@vger.kernel.org, scgl@linux.ibm.com,
	seiden@linux.ibm.com, nrb@linux.ibm.com
Subject: Re: [PATCH v13 4/6] KVM: s390: pv: avoid export before import if possible
Date: Fri, 19 Aug 2022 11:50:54 +0200	[thread overview]
Message-ID: <99a49638-1604-962e-9010-1b57111d3132@linux.ibm.com> (raw)
In-Reply-To: <20220810125625.45295-5-imbrenda@linux.ibm.com>

On 8/10/22 14:56, Claudio Imbrenda wrote:
> If the appropriate UV feature bit is set, there is no need to perform
> an export before import.
> 
> Signed-off-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
> Reviewed-by: Nico Boehr <nrb@linux.ibm.com>
> ---
>   arch/s390/kernel/uv.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/arch/s390/kernel/uv.c b/arch/s390/kernel/uv.c
> index f9810d2a267c..b455646c8d74 100644
> --- a/arch/s390/kernel/uv.c
> +++ b/arch/s390/kernel/uv.c
> @@ -255,6 +255,8 @@ static int make_secure_pte(pte_t *ptep, unsigned long addr,
>    */
>   static bool should_export_before_import(struct uv_cb_header *uvcb, struct mm_struct *mm)
>   {
The misc feature indicates that the UV will automatically transfer 
ownership from one protected VM to another when importing a shared page.


Other than that:
Reviewed-by: Janosch Frank <frankja@linux.ibm.com>


> +	if (test_bit_inv(BIT_UV_FEAT_MISC, &uv_info.uv_feature_indications))
> +		return false;
>   	if (uvcb->cmd == UVC_CMD_UNPIN_PAGE_SHARED)
>   		return false;
>   	return atomic_read(&mm->context.protected_count) > 1;