Re: [PATCH] Input: goodix - Add upside-down quirk for Teclast X89 tablet

From: Bastien Nocera <hadess@hadess.net>
To: Hans de Goede <hdegoede@redhat.com>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org
Subject: Re: [PATCH] Input: goodix - Add upside-down quirk for Teclast X89 tablet
Date: Mon, 02 Dec 2019 11:16:35 +0100	[thread overview]
Message-ID: <99ff833f27ce999e334d43ac511b6032f2668dc6.camel@hadess.net> (raw)
In-Reply-To: <20191202085636.6650-1-hdegoede@redhat.com>

On Mon, 2019-12-02 at 09:56 +0100, Hans de Goede wrote:
> The touchscreen on the Teclast X89 is mounted upside down in relation
> to
> the display orientation (the touchscreen itself is mounted upright,
> but the
> display is mounted upside-down). Add a quirk for this so that we send
> coordinates which match the display orientation.
> 
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>

Looks good

Reviewed-by: Bastien Nocera <hadess@hadess.net>

> ---
>  drivers/input/touchscreen/goodix.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/drivers/input/touchscreen/goodix.c
> b/drivers/input/touchscreen/goodix.c
> index fb43aa708660..0403102e807e 100644
> --- a/drivers/input/touchscreen/goodix.c
> +++ b/drivers/input/touchscreen/goodix.c
> @@ -128,6 +128,15 @@ static const unsigned long goodix_irq_flags[] =
> {
>   */
>  static const struct dmi_system_id rotated_screen[] = {
>  #if defined(CONFIG_DMI) && defined(CONFIG_X86)
> +	{
> +		.ident = "Teclast X89",
> +		.matches = {
> +			/* tPAD is too generic, also match on bios date
> */
> +			DMI_MATCH(DMI_BOARD_VENDOR, "TECLAST"),
> +			DMI_MATCH(DMI_BOARD_NAME, "tPAD"),
> +			DMI_MATCH(DMI_BIOS_DATE, "12/19/2014"),
> +		},
> +	},
>  	{
>  		.ident = "WinBook TW100",
>  		.matches = {