Re: multipath-tools: add INSPUR/MCS to hardware table

From: Xose Vazquez Perez <xose.vazquez@gmail.com>
To: "Tom Geng(耿芳忠)" <gengfangzhong@inspur.com>
Cc: "dm-devel@redhat.com" <dm-devel@redhat.com>
Subject: Re: multipath-tools: add INSPUR/MCS to hardware table
Date: Mon, 22 Jan 2018 15:44:37 +0100	[thread overview]
Message-ID: <9a1b0968-22f5-819a-6740-48fb52d9e765@gmail.com> (raw)
In-Reply-To: <6FA0216CBF61AE4AA9DA6744243E7853DB5C42F2@jtjnmailbox06.home.langchao.com>

On 01/22/2018 11:55 AM, Tom Geng(耿芳忠) wrote:

> I added a new device support, the history and code diff is as below, will the maintainers help to review and submit?

This patch is removing the device.

> $ git diff f7bec5e..07e7bd5

git diff 07e7bd5..f7bec5e ??? or "git format-patch -1 <commit_id>"

> *diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c*
> 
> *index c8acf3af..448effe3 100644*
> 
> *--- a/libmultipath/hwtable.c*
> 
> *+++ b/libmultipath/hwtable.c*
> 
> @@ -1181,21 +1181,6 @@static struct hwentry default_hw[] = {
> 
>                 .pgpolicy      = MULTIBUS,
> 
>                 .no_path_retry = 30,
> 
>         },
> 
> -       /*
> 
> -        * INSPUR
> 
> -        *
> 
> -        * Maintainer: Tom Geng
> 
> -        * Mail: gengfangzhong@inspur.com
> 
> -        */
> 
> -       {
> 
> -               /* AS5300/AS5500 G2 */
> 
> -               .vendor        = "INSPUR",
> 
> -               .product       = "MCS",
> 
> -               .pgpolicy      = GROUP_BY_PRIO,
> 
> -               .selector      = "round-robin 0",

Replace it with service-time, it's smarter.

> 
> -               .pgfailback    = -FAILBACK_IMMEDIATE,
> 
> -               .prio_name     = PRIO_ALUA,
> 
Please, send it with "git send-email" or plain text.

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel