From: Janosch Frank <frankja@linux.ibm.com>
To: Thomas Huth <thuth@redhat.com>, kvm@vger.kernel.org
Cc: linux-s390@vger.kernel.org, david@redhat.com
Subject: Re: [kvm-unit-tests PATCH 5/6] s390x: Prepare for external calls
Date: Mon, 2 Sep 2019 16:17:23 +0200 [thread overview]
Message-ID: <9a1ff6d5-fdd9-730c-cedf-2ec08447e8fb@linux.ibm.com> (raw)
In-Reply-To: <e32aef57-e9a0-032d-3dec-5c3227225918@redhat.com>
[-- Attachment #1.1: Type: text/plain, Size: 1298 bytes --]
On 9/2/19 3:58 PM, Thomas Huth wrote:
> On 29/08/2019 14.14, Janosch Frank wrote:
>> With SMP we also get new external interrupts like external call and
>> emergency call. Let's make them known.
>>
>> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
>> ---
>> lib/s390x/asm/arch_def.h | 5 +++++
>> lib/s390x/asm/interrupt.h | 3 +++
>> lib/s390x/interrupt.c | 24 ++++++++++++++++++++----
>> 3 files changed, 28 insertions(+), 4 deletions(-)
>>
>> diff --git a/lib/s390x/asm/arch_def.h b/lib/s390x/asm/arch_def.h
>> index d5a7f51..5ece2ce 100644
>> --- a/lib/s390x/asm/arch_def.h
>> +++ b/lib/s390x/asm/arch_def.h
>> @@ -19,6 +19,11 @@ struct psw {
>> #define PSW_MASK_DAT 0x0400000000000000UL
>> #define PSW_MASK_PSTATE 0x0001000000000000UL
>>
>> +#define CR0_EXTM_SCLP 0X0000000000000200UL
>> +#define CR0_EXTM_EXTC 0X0000000000004000UL
>> +#define CR0_EXTM_EMGC 0X0000000000008000UL
>> +#define CR0_EXTM_MASK 0X000000000001DD40UL
>
> I think I need more coffee... but if I still count right, the EXTC, EMGC
> and some of the mask bits seem to be off-by-one ? Could that be? Please
> double-check.
>
> Thomas
They are definitely wrong, but as they are not used anyway it doesn't
make a difference in the test that follows -_-
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-09-02 14:17 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-29 12:14 [kvm-unit-tests PATCH 0/6] s390x: Add multiboot and smp Janosch Frank
2019-08-29 12:14 ` [kvm-unit-tests PATCH 1/6] s390x: Use interrupts in SCLP and add locking Janosch Frank
2019-08-30 12:21 ` David Hildenbrand
2019-09-02 11:42 ` Thomas Huth
2019-09-03 7:53 ` Janosch Frank
2019-09-03 8:52 ` David Hildenbrand
2019-08-29 12:14 ` [kvm-unit-tests PATCH 2/6] s390x: Add linemode console Janosch Frank
2019-09-02 11:59 ` Thomas Huth
2019-08-29 12:14 ` [kvm-unit-tests PATCH 3/6] s390x: Add linemode buffer to fix newline on every print Janosch Frank
2019-08-29 12:14 ` [kvm-unit-tests PATCH 4/6] s390x: Add initial smp code Janosch Frank
2019-09-02 13:21 ` Thomas Huth
2019-09-03 8:10 ` Janosch Frank
2019-08-29 12:14 ` [kvm-unit-tests PATCH 5/6] s390x: Prepare for external calls Janosch Frank
2019-09-02 13:58 ` Thomas Huth
2019-09-02 14:17 ` Janosch Frank [this message]
2019-08-29 12:14 ` [kvm-unit-tests PATCH 6/6] s390x: SMP test Janosch Frank
2019-09-02 15:40 ` Thomas Huth
2019-09-03 8:44 ` Janosch Frank
2019-09-03 8:56 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a1ff6d5-fdd9-730c-cedf-2ec08447e8fb@linux.ibm.com \
--to=frankja@linux.ibm.com \
--cc=david@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.