All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joseph Qi <joseph.qi@linux.alibaba.com>
To: Jason Wang <jasowang@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>
Cc: virtualization@lists.linux-foundation.org,
	linux-block@vger.kernel.org,
	Jeffle Xu <jefflexu@linux.alibaba.com>
Subject: Re: [PATCH RFC] virtio-blk: support per-device queue depth
Date: Mon, 18 Jan 2021 14:06:16 +0800	[thread overview]
Message-ID: <9a736867-d420-26eb-3ee2-42869a069640@linux.alibaba.com> (raw)
In-Reply-To: <ab4cbc06-b629-dd35-52ac-1246d500d1c4@redhat.com>

Hi Jason,

On 1/18/21 1:25 PM, Jason Wang wrote:
> 
> On 2021/1/18 上午11:58, Joseph Qi wrote:
>> module parameter 'virtblk_queue_depth' was firstly introduced for
>> testing/benchmarking purposes described in commit fc4324b4597c
>> ("virtio-blk: base queue-depth on virtqueue ringsize or module param").
>> Since we have different virtio-blk devices which have different
>> capabilities, it requires that we support per-device queue depth instead
>> of per-module. So defaultly use vq free elements if module parameter
>> 'virtblk_queue_depth' is not set.
> 
> 
> I wonder if it's better to use sysfs instead (or whether it has already had something like this in the blocker layer).
> 
Thanks for quick response.
Do you mean adjust /sys/block/vdX/queue/nr_requests?
But current logic in virtblk_probe() is, virtblk_queue_depth is
used as a saved value for first probed vdev, not purely module
parameter.

Thanks,
Joseph   

  reply	other threads:[~2021-01-18  6:07 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-18  3:58 [PATCH RFC] virtio-blk: support per-device queue depth Joseph Qi
2021-01-18  5:25 ` Jason Wang
2021-01-18  5:25   ` Jason Wang
2021-01-18  6:06   ` Joseph Qi [this message]
2021-01-19  4:04     ` Jason Wang
2021-01-19  4:04       ` Jason Wang
2021-01-19  1:33   ` JeffleXu
2021-01-19  1:33     ` JeffleXu
2021-01-19  4:06     ` Jason Wang
2021-01-19  4:06       ` Jason Wang
2021-01-20  1:51       ` JeffleXu
2021-01-20  1:51         ` JeffleXu
2021-01-20  2:47         ` Jason Wang
2021-01-20  2:47           ` Jason Wang
2021-01-19  4:14 ` Jason Wang
2021-01-19  4:14   ` Jason Wang
2021-01-22  1:43   ` Joseph Qi
2021-01-22  8:34     ` Michael S. Tsirkin
2021-01-22  8:34       ` Michael S. Tsirkin
2021-01-22  9:13       ` Joseph Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9a736867-d420-26eb-3ee2-42869a069640@linux.alibaba.com \
    --to=joseph.qi@linux.alibaba.com \
    --cc=jasowang@redhat.com \
    --cc=jefflexu@linux.alibaba.com \
    --cc=linux-block@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.