From: Kefeng Wang <wangkefeng.wang@huawei.com>
To: David Hildenbrand <david@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>, <linux-mm@kvack.org>
Cc: Mike Rapoport <rppt@kernel.org>,
Oscar Salvador <osalvador@suse.de>,
<linux-kernel@vger.kernel.org>, Vlastimil Babka <vbabka@suse.cz>
Subject: Re: [PATCH 2/2] mm: add pageblock_aligned() macro
Date: Fri, 2 Sep 2022 17:39:43 +0800 [thread overview]
Message-ID: <9ab7d4b4-505b-0532-09fd-186814b7fc8f@huawei.com> (raw)
In-Reply-To: <2e7945e5-b0b0-bc44-c5eb-48d67532f78f@redhat.com>
On 2022/9/2 17:04, David Hildenbrand wrote:
> On 02.09.22 11:02, Kefeng Wang wrote:
>> On 2022/9/2 16:42, David Hildenbrand wrote:
>>> On 02.09.22 08:47, Kefeng Wang wrote:
>>>> Add pageblock_aligned() and use it to simplify code.
>>>>
>>>> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
>>>> ---
>>> [...]
>>>
>>>> - unsigned long nr_pgmask = pageblock_nr_pages - 1;
>>>> int nid = zone_to_nid(zone);
>>>> unsigned long nr_pages = 0;
>>>> int zid = zone_idx(zone);
>>>> @@ -1977,7 +1974,7 @@ static unsigned long __init deferred_init_pages(struct zone *zone,
>>>> if (!deferred_pfn_valid(pfn)) {
>>>> page = NULL;
>>>> continue;
>>>> - } else if (!page || !(pfn & nr_pgmask)) {
>>> I didn't sleep too well this night and am tired, please tell me why I'm
>>> wrong :)
>> Wish you have a good reset :)
> Thanks, the headache isn't helping :D
>
>>> "pfn & (pageblock_nr_pages - 1)" is true if the pageblock is not aligned
>>>
>>> E.g., pfn = 1, pageblock_nr_pages = 512
>>>
>>> pfn & (pageblock_nr_pages - 1)
>>> -> 1 & (512 - 1)
>>> -> 1 & 511
>>> -> true
>>>
>>> "!(pfn & (pageblock_nr_pages - 1))" is true if the pageblock is aligned
>>> -> !(true)
>>> -> false
>>>
>>>
>>> However, "!pageblock_aligned(1)" = true
>>>
>>>
>>>> + } else if (!page || !pageblock_aligned(pfn)) {
>> pageblock_aligned(pfn) IS_ALIGNED((unsigned long)(pfn), pageblock_nr_pages)
>>
>> #define IS_ALIGNED(x, a) (((x) & ((typeof(x))(a) - 1)) == 0) (((pfn) &
>> (pageblock_nr_pages - 1)) == 0) -> ((1 & 512 -1) == 0) -> ((1 & 511) ==
>> 0) -> ((511) == 0) -> false
>> right ?
> yes ... and inverting that would give you "true", which is not what we want?
>
oops... it's my fault, looks like I need to have a reset to save my
brain...
> Again, sorry if I'm wrong ...
>
next prev parent reply other threads:[~2022-09-02 9:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-02 6:47 [PATCH 1/2] mm: reuse pageblock_start/end_pfn() macro Kefeng Wang
2022-09-02 6:47 ` [PATCH 2/2] mm: add pageblock_aligned() macro Kefeng Wang
2022-09-02 8:42 ` David Hildenbrand
2022-09-02 9:02 ` Kefeng Wang
2022-09-02 9:04 ` David Hildenbrand
2022-09-02 9:39 ` Kefeng Wang [this message]
2022-09-02 8:20 ` [PATCH 1/2] mm: reuse pageblock_start/end_pfn() macro David Hildenbrand
2022-09-02 8:48 ` Kefeng Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ab7d4b4-505b-0532-09fd-186814b7fc8f@huawei.com \
--to=wangkefeng.wang@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=osalvador@suse.de \
--cc=rppt@kernel.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.