From: Guenter Roeck <linux@roeck-us.net>
To: Potin Lai <potin.lai.pt@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Jean Delvare <jdelvare@suse.com>,
Jonathan Corbet <corbet@lwn.net>, Mark Brown <broonie@kernel.org>,
Joel Stanley <joel@jms.id.au>,
Peter Yin <peteryin.openbmc@gmail.com>,
Peter Yin <peter.yin@quantatw.com>,
Potin Lai <potin.lai@quantatw.com>,
Patrick Williams <patrick@stwcx.xyz>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH v2 2/2] hwmon: (pmbus) Add support for MPS Multi-phase mp2856/mp2857 controller
Date: Sun, 17 Dec 2023 07:33:19 -0800 [thread overview]
Message-ID: <9abe3c01-f6ba-4791-9cf8-d73dfe44d899@roeck-us.net> (raw)
In-Reply-To: <20231211160519.21254-3-potin.lai.pt@gmail.com>
On Tue, Dec 12, 2023 at 12:05:19AM +0800, Potin Lai wrote:
> From: Peter Yin <peteryin.openbmc@gmail.com>
>
> Add support for mp2856/mp2857 device from Monolithic Power Systems, Inc.
> (MPS) vendor. This is a dual-loop, digital, multi-phase,
> modulation controller.
>
> Signed-off-by: Peter Yin <peteryin.openbmc@gmail.com>
> Signed-off-by: Potin Lai <potin.lai.pt@gmail.com>
Applied, with reservations (because due to lack of datasheet it is all but
impossible to validate the code) and several fixups. So this driver comes
with even less warranty than usual.
CHECK: Alignment should match open parenthesis
#671: FILE: drivers/hwmon/pmbus/mp2856.c:413:
+ memcpy(data->max_phases, mp2856_max_phases[data->chip_id],
+ sizeof(data->max_phases));
CHECK: Please don't use multiple blank lines
#673: FILE: drivers/hwmon/pmbus/mp2856.c:415:
+
+
CHECK: Please don't use multiple blank lines
#707: FILE: drivers/hwmon/pmbus/mp2856.c:449:
+
+
Fix those, and use i2c_get_match_data().
_Please_ run your patches through checkpatch. The above is really
completely unnecessary and creates unnecessary extra work for others (me).
Guenter
next prev parent reply other threads:[~2023-12-17 15:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-11 16:05 [PATCH v2 0/2] hwmon: (pmbus) Add support for MPS Multi-phase mp2856/mp2857 controller Potin Lai
2023-12-11 16:05 ` [PATCH v2 1/2] dt-bindings: Add MP2856/MP2857 voltage regulator device Potin Lai
2023-12-17 15:19 ` Guenter Roeck
2023-12-11 16:05 ` [PATCH v2 2/2] hwmon: (pmbus) Add support for MPS Multi-phase mp2856/mp2857 controller Potin Lai
2023-12-17 15:33 ` Guenter Roeck [this message]
2023-12-18 2:43 ` Potin Lai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9abe3c01-f6ba-4791-9cf8-d73dfe44d899@roeck-us.net \
--to=linux@roeck-us.net \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=joel@jms.id.au \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patrick@stwcx.xyz \
--cc=peter.yin@quantatw.com \
--cc=peteryin.openbmc@gmail.com \
--cc=potin.lai.pt@gmail.com \
--cc=potin.lai@quantatw.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.