From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Dmitry Osipenko <digetx@gmail.com>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Anton Bambura <jenneron@protonmail.com>,
Matt Merhar <mattmerhar@protonmail.com>,
Peter Geis <pgwipeout@gmail.com>
Cc: linux-pm@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH RESEND v2 2/2] cpuidle: tegra: Remove do_idle firmware call
Date: Tue, 2 Mar 2021 13:57:57 +0100 [thread overview]
Message-ID: <9b744a38-5f43-00bb-1972-86a30efaaa96@linaro.org> (raw)
In-Reply-To: <1da82ae3-6b23-2aa0-3275-309ffd8738d0@gmail.com>
On 02/03/2021 13:51, Dmitry Osipenko wrote:
> 02.03.2021 15:45, Daniel Lezcano пишет:
>> On 02/03/2021 10:54, Dmitry Osipenko wrote:
>>> The do_idle firmware call is unused by all Tegra SoCs, hence remove it in
>>> order to keep driver's code clean.
>>>
>>> Tested-by: Anton Bambura <jenneron@protonmail.com> # TF701 T114
>>> Tested-by: Matt Merhar <mattmerhar@protonmail.com> # Ouya T30
>>> Tested-by: Peter Geis <pgwipeout@gmail.com> # Ouya T30
>>> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
>>> ---
[ ... ]
>>> if (!IS_ENABLED(CONFIG_PM_SLEEP)) {
>>> - if (!tegra_cpuidle_using_firmware())
>>> - tegra_cpuidle_disable_state(TEGRA_C7);
>>
>> So firmware_ops->do_idle is always NULL, thus
>> tegra_cpuidle_using_firmware() is always false and
>> tegra_cpuidle_disable_state() always called, right ?
>
> Yes, the tegra_cpuidle_disable_state(TEGRA_C7) is always
> called if CONFIG_PM_SLEEP is disabled in kernel config.
Ok, thanks.
Reviewed-by: Daniel Lezcano <daniel.lezcano@linaro.org>
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2021-03-03 3:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-02 9:54 [PATCH RESEND v2 1/2] cpuidle: tegra: Fix C7 idling state on Tegra114 Dmitry Osipenko
2021-03-02 9:54 ` [PATCH RESEND v2 2/2] cpuidle: tegra: Remove do_idle firmware call Dmitry Osipenko
2021-03-02 12:45 ` Daniel Lezcano
2021-03-02 12:51 ` Dmitry Osipenko
2021-03-02 12:57 ` Daniel Lezcano [this message]
2021-03-04 14:22 ` Daniel Lezcano
2021-03-02 12:36 ` [PATCH RESEND v2 1/2] cpuidle: tegra: Fix C7 idling state on Tegra114 Daniel Lezcano
2021-03-04 13:55 ` Rafael J. Wysocki
2021-03-04 14:05 ` Daniel Lezcano
2021-03-04 14:08 ` Rafael J. Wysocki
2021-03-04 14:09 ` Daniel Lezcano
2021-03-04 14:21 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b744a38-5f43-00bb-1972-86a30efaaa96@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=digetx@gmail.com \
--cc=jenneron@protonmail.com \
--cc=jonathanh@nvidia.com \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mattmerhar@protonmail.com \
--cc=pgwipeout@gmail.com \
--cc=rjw@rjwysocki.net \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.