[PATCH RFC 2/9] drm/omap: Fail probe if irq registration fails

From: Jyri Sarha <jsarha@ti.com>
To: dri-devel@lists.freedesktop.org, tomi.valkeinen@ti.com,
	laurent.pinchart@ideasonboard.com
Cc: Jyri Sarha <jsarha@ti.com>
Subject: [PATCH RFC 2/9] drm/omap: Fail probe if irq registration fails
Date: Fri, 16 Feb 2018 13:25:03 +0200	[thread overview]
Message-ID: <9b81b22145e303cb33df02b6770e295c7418bad2.1518780268.git.jsarha@ti.com> (raw)
In-Reply-To: <cover.1518780267.git.jsarha@ti.com>

Call to omap_drm_irq_install() may fail with an error code. In such a
case the driver probe should fail.

Signed-off-by: Jyri Sarha <jsarha@ti.com>
Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
---
 drivers/gpu/drm/omapdrm/omap_drv.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/omapdrm/omap_drv.c b/drivers/gpu/drm/omapdrm/omap_drv.c
index 65a567d..979bede 100644
--- a/drivers/gpu/drm/omapdrm/omap_drv.c
+++ b/drivers/gpu/drm/omapdrm/omap_drv.c
@@ -321,7 +321,9 @@ static int omap_modeset_init(struct drm_device *dev)
 
 	drm_mode_config_reset(dev);
 
-	omap_drm_irq_install(dev);
+	ret = omap_drm_irq_install(dev);
+	if (ret)
+		return ret;
 
 	return 0;
 }
-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
