From: osalvador@suse.de
To: Aristeu Rozanski <aris@ruivo.org>
Cc: naoya.horiguchi@nec.com, akpm@linux-foundation.org,
mhocko@kernel.org, tony.luck@intel.com, cai@lca.pw,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH v3 0/5] HWpoison: further fixes and cleanups
Date: Wed, 16 Sep 2020 18:30:56 +0200 [thread overview]
Message-ID: <9bd7ac81968a7897474804d53bfc1286@suse.de> (raw)
In-Reply-To: <20200916144603.GC17169@cathedrallabs.org>
On 2020-09-16 16:46, Aristeu Rozanski wrote:
> Hi Oscar,
>
> On Wed, Sep 16, 2020 at 04:09:30PM +0200, Oscar Salvador wrote:
>> On Wed, Sep 16, 2020 at 09:53:58AM -0400, Aristeu Rozanski wrote:
>> Can you try the other patch I posted in response to Naoya?
>
> Same thing:
>
> [ 369.195056] Soft offlining pfn 0x3fb5bf at process virtual address
> 0x7ffc84350000
> [ 369.195073] page:000000002bb131e4 refcount:1 mapcount:0
> mapping:0000000000000000 index:0x7ffc8435 pfn:0x3fb5bf
> [ 369.195080] anon flags:
> 0x3ffff80008000e(referenced|uptodate|dirty|swapbacked)
> [ 369.202131] raw: 003ffff80008000e 5deadbeef0000100 5deadbeef0000122
> c000003fda1c7431
> [ 369.202137] raw: 000000007ffc8435 0000000000000000 00000001ffffffff
> c000003fd63af000
> [ 369.202141] page dumped because: page_handle_poison
> [ 369.202145] page->mem_cgroup:c000003fd63af000
> [ 369.215055] page_handle_poison: hugepage_or_freepage failed�n
> [ 369.215057] __soft_offline_page: page_handle_poison -EBUSY
> [ 369.215068] page:000000002bb131e4 refcount:3 mapcount:0
> mapping:00000000f6ca3f32 index:0x5c pfn:0x3fb5bf
> [ 369.215110] aops:xfs_address_space_operations [xfs] ino:49f9c5f
> dentry name:"messages"
> [ 369.215117] flags: 0x3ffff800002008(dirty|private)
> [ 369.215121] raw: 003ffff800002008 5deadbeef0000100 5deadbeef0000122
> c000003fadd3daa8
> [ 369.215127] raw: 000000000000005c c000003fd9497c20 00000003ffffffff
> c000003fd1143000
> [ 369.215132] page dumped because: __soft_offline_page after migrate
> [ 369.215136] page->mem_cgroup:c000003fd1143000
Ok, this is something different.
The race you saw previously is kinda normal as there is a race window
between spotting a freepage and taking it off the buddy freelists.
The retry patch should help there.
The issue you are seeing right here is due to the call to
page_handle_poison in __soft_offline_page being wrong, as we pass
hugepage_or_freepage = true inconditionally, which is wrong.
Should be:
next prev parent reply other threads:[~2020-09-16 20:43 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-14 10:15 [PATCH v3 0/5] HWpoison: further fixes and cleanups Oscar Salvador
2020-09-14 10:15 ` [PATCH v3 1/5] mm,hwpoison: take free pages off the buddy freelists Oscar Salvador
2020-09-14 10:15 ` [PATCH v3 2/5] mm,hwpoison: refactor madvise_inject_error Oscar Salvador
2020-09-14 10:15 ` [PATCH v3 3/5] mm,hwpoison: drain pcplists before bailing out for non-buddy zero-refcount page Oscar Salvador
2020-09-14 10:15 ` [PATCH v3 4/5] mm,hwpoison: drop unneeded pcplist draining Oscar Salvador
2020-09-14 10:15 ` [PATCH v3 5/5] mm,hwpoison: remove stale code Oscar Salvador
2020-09-15 21:22 ` [PATCH v3 0/5] HWpoison: further fixes and cleanups Aristeu Rozanski
2020-09-16 7:27 ` Oscar Salvador
2020-09-16 13:53 ` Aristeu Rozanski
2020-09-16 14:09 ` Oscar Salvador
2020-09-16 14:46 ` Aristeu Rozanski
2020-09-16 16:30 ` osalvador [this message]
2020-09-16 16:34 ` osalvador
2020-09-16 17:58 ` Aristeu Rozanski
2020-09-16 18:12 ` osalvador
2020-09-16 13:42 ` HORIGUCHI NAOYA(堀口 直也)
2020-09-16 14:06 ` Oscar Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9bd7ac81968a7897474804d53bfc1286@suse.de \
--to=osalvador@suse.de \
--cc=akpm@linux-foundation.org \
--cc=aris@ruivo.org \
--cc=cai@lca.pw \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=naoya.horiguchi@nec.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.