From: John Hubbard <jhubbard@nvidia.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Linux Next <linux-next@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>
Subject: Re: [PATCH v2 2/2] selftests/vm: fix run_vmtest.sh: restore executable bits, and "s" in name
Date: Fri, 2 Oct 2020 15:04:48 -0700 [thread overview]
Message-ID: <9c41820b-05d5-8e62-2ef2-ab82d5e02f06@nvidia.com> (raw)
In-Reply-To: <20201002145945.c5abb5f57dbeac30351b7757@linux-foundation.org>
On 10/2/20 2:59 PM, Andrew Morton wrote:
> On Fri, 2 Oct 2020 01:40:49 -0700 John Hubbard <jhubbard@nvidia.com> wrote:
>
>> commit cb2ab76685d7 ("selftests/vm: rename run_vmtests -->
>> run_vmtests.sh") changed the name of run_vmtests to run_vmtest.sh, but
>> inadvertently dropped the executable bits.
>
> We cannot depend on the x bit. Because downloading linux-foo.patch.gz
> and installing it with patch(1) is a supported way of obtaining Linux.
> And patch(1) loses the x bit.
OK. I was just hoping that, within our processes here, there's still some
way to get something committed that does have the bit set. Because it's a
nice touch to be able to do
./run_vmtests.sh
Not a big deal of course.
>
> If $(CONFIG_SHELL) is unavailable then invoking the script with
> "/bin/sh foo.sh" should do the trick.
OK, I'll use that for the Makefile.
>
>> Somehow the name is missing an "s", too. Fix both of these problems by
>> renaming, and restoring the executable bits.
>
> But that's what your patch did!
>
> tools/testing/selftests/vm/{run_vmtests => run_vmtest.sh} | 0
>
> Here: https://lkml.kernel.org/r/20200929212747.251804-4-jhubbard@nvidia.com
>
Yes, the dropped "s" is my mistake!
>
> So all confused. I'll drop this version - please redo and resend when
> convenient?
>
Coming up, sorry about the mess here!
thanks,
--
John Hubbard
NVIDIA
prev parent reply other threads:[~2020-10-02 22:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-02 8:40 [PATCH v2 0/2] selftests/vm: fix up executable bits, and a file name John Hubbard
2020-10-02 8:40 ` [PATCH v2 1/2] selftests/vm: fix: make check_config.sh executable John Hubbard
2020-10-02 8:40 ` [PATCH v2 2/2] selftests/vm: fix run_vmtest.sh: restore executable bits, and "s" in name John Hubbard
2020-10-02 21:59 ` Andrew Morton
2020-10-02 22:04 ` John Hubbard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c41820b-05d5-8e62-2ef2-ab82d5e02f06@nvidia.com \
--to=jhubbard@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.