From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
Claudio Fontana <cfontana@suse.de>,
Stefan Hajnoczi <stefanha@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Subject: Re: [RFC PATCH v2] meson: Only generate trace files for selected targets
Date: Tue, 9 Mar 2021 11:54:49 +0100 [thread overview]
Message-ID: <9cf0f38a-3b9c-6f18-e5f2-9be31c708312@redhat.com> (raw)
In-Reply-To: <7ff2c1ed-e6ad-4a6f-3552-be5ba90960d7@redhat.com>
On 3/9/21 11:26 AM, Paolo Bonzini wrote:
> On 09/03/21 09:41, Claudio Fontana wrote:
>> In any case, I agree that just recursing all directories in target/
>> looking for trace.h / traceevents files could be better.
>
> Using the directory structure to find source files is a bad idea because
> you don't notice that you haven't "git add"ed a file until it's too late
> (typically the maintainer notices it for you...).
>
> We do it for default-configs/targets, but that's an exception and I'd
> rather not extend it more.
>
> In fact, Philippe, perhaps you can add the extra tracedirs for hw/ and
> target/ to the default-config/targets/*.mak file?
Hmm interesting idea... I'll have a look, thanks!
prev parent reply other threads:[~2021-03-09 11:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-24 21:35 [RFC PATCH v2] meson: Only generate trace files for selected targets Philippe Mathieu-Daudé
2021-03-08 16:46 ` Stefan Hajnoczi
2021-03-08 17:48 ` Philippe Mathieu-Daudé
2021-03-09 8:41 ` Claudio Fontana
2021-03-09 9:21 ` Philippe Mathieu-Daudé
2021-03-09 10:26 ` Paolo Bonzini
2021-03-09 10:46 ` Claudio Fontana
2021-03-09 10:54 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9cf0f38a-3b9c-6f18-e5f2-9be31c708312@redhat.com \
--to=philmd@redhat.com \
--cc=cfontana@suse.de \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.