Re: [PATCH] selftests/livepatch: add test skip handling

From: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
To: Joe Lawrence <joe.lawrence@redhat.com>,
	live-patching@vger.kernel.org, linux-kselftest@vger.kernel.org
Cc: shuah@kernel.org
Subject: Re: [PATCH] selftests/livepatch: add test skip handling
Date: Mon, 15 Jul 2019 12:20:37 +0530	[thread overview]
Message-ID: <9de46fed-785c-d5c4-8a76-205674bd0912@linux.vnet.ibm.com> (raw)
In-Reply-To: <20190714142829.29458-1-joe.lawrence@redhat.com>

On 7/14/19 7:58 PM, Joe Lawrence wrote:
> Before running a livpeatch self-test, first verify that we've built and
> installed the livepatch self-test kernel modules by running a 'modprobe
> --dry-run'.  This should catch a few environment issues, including
> !CONFIG_LIVEPATCH and !CONFIG_TEST_LIVEPATCH.  In these cases, exit
> gracefully with test-skip status rather than test-fail status.
> 
> Reported-by: Jiri Benc <jbenc@redhat.com>
> Suggested-by: Shuah Khan <shuah@kernel.org>
> Signed-off-by: Joe Lawrence <joe.lawrence@redhat.com>

Reviewed-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>

[...]
> 
> +function assert_mod() {
> +	local mod="$1"
> +
> +	if ! modprobe --dry-run "$mod" &>/dev/null ; then

Just a preference comment, shorter version 'modprobe -q -n'
can be used here.

Thanks,
Kamalesh