From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, irina.tirdea@intel.com,
tiwai@suse.de, mturquette@baylibre.com,
Stephen Boyd <sboyd@codeaurora.org>,
linux-clk@vger.kernel.org
Subject: Re: [alsa-devel] [PATCH] clk: x86: Add Atom PMC platform clocks
Date: Thu, 1 Sep 2016 18:32:44 -0500 [thread overview]
Message-ID: <9df1be06-8415-8cff-9468-0c4938f6e0fc@linux.intel.com> (raw)
In-Reply-To: <20160831170858.GA6560@sirena.org.uk>
On 8/31/16 12:08 PM, Mark Brown wrote:
> On Tue, Aug 30, 2016 at 08:35:55PM -0500, Pierre-Louis Bossart wrote:
>> On 8/30/16 7:37 PM, Stephen Boyd wrote:
>
>>> It's sad that this can't be compiled on any platform. Has there
>>> been any move towards making this into a regmap provider so that
>>> this clk driver can use cross platform regmap APIs instead? Or
>
>> it's not clear to me what cross-platform goals you are hinting at and what
>> the concern is. We can add more framework stuff and make the code more
>> elegant but at the end of the day we will write in a very limited set of
>> registers (2 for audio - on/off and 19.2/25MHz selection) and the use of
>> this functionality is restricted to Baytrail and Cherrytrail.
>
> If code can be compiled on a wide range of platforms then that means
> that it's much easier to get build coverage of the code. This is
> helpful for anyone doing any kind of cross tree updates - things like
> updating APIs for example. The fewer configurations they have to touch
> to get everything built the easier it is for them.
ok, we can add a dummy pmc_write/read for non atom platforms so that
changes in the clock framework API can be handled without configuration.
Using regmap to hide the IPC requests to the PCM seems a bit
over-engineered - we are talking about 2 registers per clock - and bring
limited benefits.
next prev parent reply other threads:[~2016-09-01 23:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-17 18:41 [PATCH] clk: x86: Add Atom PMC platform clocks Pierre-Louis Bossart
2016-08-17 18:41 ` Pierre-Louis Bossart
2016-08-31 0:37 ` Stephen Boyd
2016-08-31 1:35 ` Pierre-Louis Bossart
2016-08-31 17:08 ` Mark Brown
2016-09-01 23:32 ` Pierre-Louis Bossart [this message]
2016-09-03 0:31 ` [alsa-devel] " Stephen Boyd
2016-09-03 0:31 ` Stephen Boyd
2016-08-31 22:34 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9df1be06-8415-8cff-9468-0c4938f6e0fc@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=irina.tirdea@intel.com \
--cc=linux-clk@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@codeaurora.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.