Re: [PATCH 11/41] rtc: ds1685: Convert to platform remove callback returning void

From: Joshua Kinard <kumba@gentoo.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Alessandro Zummo" <a.zummo@towertech.it>,
	"Alexandre Belloni" <alexandre.belloni@bootlin.com>
Cc: linux-rtc@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH 11/41] rtc: ds1685: Convert to platform remove callback returning void
Date: Mon, 6 Mar 2023 14:43:20 -0500	[thread overview]
Message-ID: <9e2df07f-92d3-966a-5092-22572e102253@gentoo.org> (raw)
In-Reply-To: <20230304133028.2135435-12-u.kleine-koenig@pengutronix.de>

On 3/4/2023 08:29, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
> 
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
>   drivers/rtc/rtc-ds1685.c | 6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/rtc/rtc-ds1685.c b/drivers/rtc/rtc-ds1685.c
> index 5db9c737c022..0f707be0eb87 100644
> --- a/drivers/rtc/rtc-ds1685.c
> +++ b/drivers/rtc/rtc-ds1685.c
> @@ -1322,7 +1322,7 @@ ds1685_rtc_probe(struct platform_device *pdev)
>    * ds1685_rtc_remove - removes rtc driver.
>    * @pdev: pointer to platform_device structure.
>    */
> -static int
> +static void
>   ds1685_rtc_remove(struct platform_device *pdev)
>   {
>   	struct ds1685_priv *rtc = platform_get_drvdata(pdev);
> @@ -1344,8 +1344,6 @@ ds1685_rtc_remove(struct platform_device *pdev)
>   	rtc->write(rtc, RTC_EXT_CTRL_4A,
>   		   (rtc->read(rtc, RTC_EXT_CTRL_4A) &
>   		    ~(RTC_CTRL_4A_RWK_MASK)));
> -
> -	return 0;
>   }
>   
>   /*
> @@ -1356,7 +1354,7 @@ static struct platform_driver ds1685_rtc_driver = {
>   		.name	= "rtc-ds1685",
>   	},
>   	.probe		= ds1685_rtc_probe,
> -	.remove		= ds1685_rtc_remove,
> +	.remove_new	= ds1685_rtc_remove,
>   };
>   module_platform_driver(ds1685_rtc_driver);
>   /* ----------------------------------------------------------------------- */

Is there a future planned patch that would remove the .remove member and then rename .remove_new --> .remove?

-- 
Joshua Kinard
Gentoo/MIPS
kumba@gentoo.org
rsa6144/5C63F4E3F5C6C943 2015-04-27
177C 1972 1FB8 F254 BAD0 3E72 5C63 F4E3 F5C6 C943

"The past tempts us, the present confuses us, the future frightens us.  And our lives slip away, moment by 
moment, lost in that vast, terrible in-between."

         --Emperor Turhan, Centauri Republic