From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, qemu-devel@nongnu.org
Cc: damien.hedde@greensocs.com, peter.maydell@linaro.org,
sstabellini@kernel.org, edgar.iglesias@xilinx.com,
sai.pavan.boddu@xilinx.com, frasse.iglesias@gmail.com,
jasowang@redhat.com, alistair@alistair23.me,
frederic.konrad@adacore.com, qemu-arm@nongnu.org,
figlesia@xilinx.com, luc.michel@greensocs.com
Subject: Re: [PATCH v2 2/9] hw/net/xilinx_axienet: Cleanup stream->push assignment
Date: Wed, 6 May 2020 13:38:50 +0200 [thread overview]
Message-ID: <9e75e512-c09f-8c48-1971-fecc4850ffc1@amsat.org> (raw)
In-Reply-To: <20200506082513.18751-3-edgar.iglesias@gmail.com>
On 5/6/20 10:25 AM, Edgar E. Iglesias wrote:
> From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>
>
> Split the shared stream_class_init function to assign
> stream->push with better type-safety.
>
> Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
> Reviewed-by: Francisco Iglesias <frasse.iglesias@gmail.com>
> Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> hw/net/xilinx_axienet.c | 18 ++++++++++++------
> 1 file changed, 12 insertions(+), 6 deletions(-)
>
> diff --git a/hw/net/xilinx_axienet.c b/hw/net/xilinx_axienet.c
> index 0f97510d8a..84073753d7 100644
> --- a/hw/net/xilinx_axienet.c
> +++ b/hw/net/xilinx_axienet.c
> @@ -1029,11 +1029,19 @@ static void xilinx_enet_class_init(ObjectClass *klass, void *data)
> dc->reset = xilinx_axienet_reset;
> }
>
> -static void xilinx_enet_stream_class_init(ObjectClass *klass, void *data)
> +static void xilinx_enet_control_stream_class_init(ObjectClass *klass,
> + void *data)
> {
> StreamSlaveClass *ssc = STREAM_SLAVE_CLASS(klass);
>
> - ssc->push = data;
> + ssc->push = xilinx_axienet_control_stream_push;
> +}
> +
> +static void xilinx_enet_data_stream_class_init(ObjectClass *klass, void *data)
> +{
> + StreamSlaveClass *ssc = STREAM_SLAVE_CLASS(klass);
> +
> + ssc->push = xilinx_axienet_data_stream_push;
> }
>
> static const TypeInfo xilinx_enet_info = {
> @@ -1048,8 +1056,7 @@ static const TypeInfo xilinx_enet_data_stream_info = {
> .name = TYPE_XILINX_AXI_ENET_DATA_STREAM,
> .parent = TYPE_OBJECT,
> .instance_size = sizeof(struct XilinxAXIEnetStreamSlave),
> - .class_init = xilinx_enet_stream_class_init,
> - .class_data = xilinx_axienet_data_stream_push,
> + .class_init = xilinx_enet_data_stream_class_init,
> .interfaces = (InterfaceInfo[]) {
> { TYPE_STREAM_SLAVE },
> { }
> @@ -1060,8 +1067,7 @@ static const TypeInfo xilinx_enet_control_stream_info = {
> .name = TYPE_XILINX_AXI_ENET_CONTROL_STREAM,
> .parent = TYPE_OBJECT,
> .instance_size = sizeof(struct XilinxAXIEnetStreamSlave),
> - .class_init = xilinx_enet_stream_class_init,
> - .class_data = xilinx_axienet_control_stream_push,
> + .class_init = xilinx_enet_control_stream_class_init,
> .interfaces = (InterfaceInfo[]) {
> { TYPE_STREAM_SLAVE },
> { }
>
next prev parent reply other threads:[~2020-05-06 11:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-06 8:25 [PATCH v2 0/9] hw/core: stream: Add end-of-packet flag Edgar E. Iglesias
2020-05-06 8:25 ` [PATCH v2 1/9] hw/net/xilinx_axienet: Auto-clear PHY Autoneg Edgar E. Iglesias
2020-05-06 8:25 ` [PATCH v2 2/9] hw/net/xilinx_axienet: Cleanup stream->push assignment Edgar E. Iglesias
2020-05-06 11:38 ` Philippe Mathieu-Daudé [this message]
2020-05-06 8:25 ` [PATCH v2 3/9] hw/net/xilinx_axienet: Remove unncessary cast Edgar E. Iglesias
2020-05-06 11:39 ` Philippe Mathieu-Daudé
2020-05-06 8:25 ` [PATCH v2 4/9] hw/dma/xilinx_axidma: Add DMA memory-region property Edgar E. Iglesias
2020-05-06 11:42 ` Philippe Mathieu-Daudé
2020-05-06 8:25 ` [PATCH v2 5/9] hw/core: stream: Add an end-of-packet flag Edgar E. Iglesias
2020-05-06 11:53 ` Philippe Mathieu-Daudé
2020-05-06 12:42 ` Edgar E. Iglesias
2020-05-06 8:25 ` [PATCH v2 6/9] hw/net/xilinx_axienet: Handle fragmented packets from DMA Edgar E. Iglesias
2020-05-06 8:25 ` [PATCH v2 7/9] hw/dma/xilinx_axidma: mm2s: Stream descriptor by descriptor Edgar E. Iglesias
2020-05-06 8:25 ` [PATCH v2 8/9] hw/dma/xilinx_axidma: s2mm: Support stream fragments Edgar E. Iglesias
2020-05-06 8:25 ` [PATCH v2 9/9] MAINTAINERS: Add myself as streams maintainer Edgar E. Iglesias
2020-05-06 11:54 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e75e512-c09f-8c48-1971-fecc4850ffc1@amsat.org \
--to=f4bug@amsat.org \
--cc=alistair@alistair23.me \
--cc=damien.hedde@greensocs.com \
--cc=edgar.iglesias@gmail.com \
--cc=edgar.iglesias@xilinx.com \
--cc=figlesia@xilinx.com \
--cc=frasse.iglesias@gmail.com \
--cc=frederic.konrad@adacore.com \
--cc=jasowang@redhat.com \
--cc=luc.michel@greensocs.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=sai.pavan.boddu@xilinx.com \
--cc=sstabellini@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.