From: Guenter Roeck <linux@roeck-us.net>
To: Osama Muhammad <osmtendev@gmail.com>
Cc: jdelvare@suse.com, linux-hwmon@vger.kernel.org
Subject: Re: [PATCH v2] hwmon:(pmbus/ucd9000): Drop unnecessary error check for debugfs_create_dir
Date: Fri, 26 May 2023 14:07:38 -0700 [thread overview]
Message-ID: <9e9f9b29-f1e5-48aa-93e1-a9f7a664f355@roeck-us.net> (raw)
In-Reply-To: <20230526154906.6370-1-osmtendev@gmail.com>
On Fri, May 26, 2023 at 08:49:06PM +0500, Osama Muhammad wrote:
> This patch removes the error checking for debugfs_create_dir
> in ucd9000.c. This is because the debugfs_create_dir() does not
> return NULL but an ERR_PTR after an error.
> The DebugFS kernel API is developed in a way that the
> caller can safely ignore the errors that occur during
> the creation of DebugFS nodes.The debugfs Api handles
> it gracefully. The check is unnecessary.
>
> Link to the comment above debugfs_create_dir:
> https://elixir.bootlin.com/linux/latest/source/fs/debugfs/inode.c#L565
>
> Signed-off-by: Osama Muhammad <osmtendev@gmail.com>
Applied.
Thanks,
Guenter
> ---
> changes since v1
> -Added more descriptive commit message.
> ---
> drivers/hwmon/pmbus/ucd9000.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/hwmon/pmbus/ucd9000.c b/drivers/hwmon/pmbus/ucd9000.c
> index 3daaf2237832..73559afa8ba7 100644
> --- a/drivers/hwmon/pmbus/ucd9000.c
> +++ b/drivers/hwmon/pmbus/ucd9000.c
> @@ -512,8 +512,6 @@ static int ucd9000_init_debugfs(struct i2c_client *client,
> return -ENOENT;
>
> data->debugfs = debugfs_create_dir(client->name, debugfs);
> - if (!data->debugfs)
> - return -ENOENT;
>
> /*
> * Of the chips this driver supports, only the UCD9090, UCD90160,
prev parent reply other threads:[~2023-05-26 21:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-26 15:49 [PATCH v2] hwmon:(pmbus/ucd9000): Drop unnecessary error check for debugfs_create_dir Osama Muhammad
2023-05-26 21:07 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e9f9b29-f1e5-48aa-93e1-a9f7a664f355@roeck-us.net \
--to=linux@roeck-us.net \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=osmtendev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.