From: Cezary Rojewski <cezary.rojewski@intel.com>
To: Lucas Stach <l.stach@pengutronix.de>
Cc: alsa-devel@alsa-project.org, Timur Tabi <timur@kernel.org>,
Xiubo Li <Xiubo.Lee@gmail.com>, Angus Ainslie <angus@akkea.ca>,
Liam Girdwood <lgirdwood@gmail.com>,
patchwork-lst@pengutronix.de,
Nicolin Chen <nicoleotsuka@gmail.com>,
Mark Brown <broonie@kernel.org>,
NXP Linux Team <linux-imx@nxp.com>,
kernel@pengutronix.de, Fabio Estevam <festevam@gmail.com>
Subject: Re: [PATCH 3/3] ASoC: fsl_sai: add i.MX8M support
Date: Thu, 18 Jul 2019 21:11:13 +0200 [thread overview]
Message-ID: <9ebe242b-ceac-6064-5b8b-698068fa11f0@intel.com> (raw)
In-Reply-To: <20190717105635.18514-4-l.stach@pengutronix.de>
On 2019-07-17 12:56, Lucas Stach wrote:
> static const struct fsl_sai_soc_data fsl_sai_vf610_data = {
> .use_imx_pcm = false,
> + .has_version_registers = false,
> .fifo_depth = 32,
> };
>
> static const struct fsl_sai_soc_data fsl_sai_imx6sx_data = {
> .use_imx_pcm = true,
> + .has_version_registers = false,
> .fifo_depth = 32,
> };
>
> +static const struct fsl_sai_soc_data fsl_sai_imx8m_data = {
> + .use_imx_pcm = true,
> + .has_version_registers = true,
> + .fifo_depth = 128,
> +};
> +
> static const struct of_device_id fsl_sai_ids[] = {
> { .compatible = "fsl,vf610-sai", .data = &fsl_sai_vf610_data },
> { .compatible = "fsl,imx6sx-sai", .data = &fsl_sai_imx6sx_data },
> { .compatible = "fsl,imx6ul-sai", .data = &fsl_sai_imx6sx_data },
> + { .compatible = "fsl,imx8mq-sai", .data = &fsl_sai_imx8m_data },
> { /* sentinel */ }
> };
These datas are populating quite rapidly. If you're planning for adding
more (and/ or appending additional fields), declaring helper macro could
prove useful.
Czarek
next prev parent reply other threads:[~2019-07-18 19:11 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-17 10:56 [PATCH 0/3] i.MX8M support for FSL SAI Lucas Stach
2019-07-17 10:56 ` [PATCH 1/3] ASoC: fsl_sai: add of_match data Lucas Stach
2019-07-17 13:42 ` Angus Ainslie
2019-07-17 14:17 ` Daniel Baluta
2019-07-22 12:22 ` Applied "ASoC: fsl_sai: add of_match data" to the asoc tree Mark Brown
2019-07-17 10:56 ` [PATCH 2/3] ASoC: fsl_sai: derive TX FIFO watermark from FIFO depth Lucas Stach
2019-07-17 13:43 ` Angus Ainslie
2019-07-22 12:22 ` Applied "ASoC: fsl_sai: derive TX FIFO watermark from FIFO depth" to the asoc tree Mark Brown
2019-07-17 10:56 ` [PATCH 3/3] ASoC: fsl_sai: add i.MX8M support Lucas Stach
2019-07-17 13:45 ` Angus Ainslie
2019-07-22 10:39 ` Daniel Baluta
2019-07-22 13:41 ` Angus Ainslie
2019-07-17 14:16 ` Daniel Baluta
2019-07-17 14:33 ` Lucas Stach
2019-07-17 15:06 ` Daniel Baluta
2019-07-17 15:15 ` Angus Ainslie
2019-07-18 8:35 ` Daniel Baluta
2019-07-18 19:11 ` Cezary Rojewski [this message]
2019-07-18 19:22 ` Daniel Baluta
2019-07-18 20:19 ` Cezary Rojewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ebe242b-ceac-6064-5b8b-698068fa11f0@intel.com \
--to=cezary.rojewski@intel.com \
--cc=Xiubo.Lee@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=angus@akkea.ca \
--cc=broonie@kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=lgirdwood@gmail.com \
--cc=linux-imx@nxp.com \
--cc=nicoleotsuka@gmail.com \
--cc=patchwork-lst@pengutronix.de \
--cc=timur@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.