From: ganqixin <ganqixin@huawei.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: "thuth@redhat.com" <thuth@redhat.com>,
Zhanghailiang <zhang.zhanghailiang@huawei.com>,
"qemu-trivial@nongnu.org" <qemu-trivial@nongnu.org>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"Chenqun (kuhn)" <kuhn.chenqun@huawei.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: RE: [PATCH 09/13] u2f-passthru: put it into the 'usb' category
Date: Tue, 17 Nov 2020 13:40:23 +0000 [thread overview]
Message-ID: <A5B86EC83C48EF4CB2BC58BEF3A2F496065C37E3@DGGEMI525-MBS.china.huawei.com> (raw)
In-Reply-To: <20201117065833.l3gsr4tryrg5dudn@sirius.home.kraxel.org>
> -----Original Message-----
> From: Gerd Hoffmann [mailto:kraxel@redhat.com]
> Sent: Tuesday, November 17, 2020 2:59 PM
> To: Philippe Mathieu-Daudé <philmd@redhat.com>
> Cc: ganqixin <ganqixin@huawei.com>; qemu-devel@nongnu.org;
> qemu-trivial@nongnu.org; Marc-André Lureau
> <marcandre.lureau@redhat.com>; thuth@redhat.com; Chenqun (kuhn)
> <kuhn.chenqun@huawei.com>; Zhanghailiang
> <zhang.zhanghailiang@huawei.com>; Eduardo Habkost
> <ehabkost@redhat.com>
> Subject: Re: [PATCH 09/13] u2f-passthru: put it into the 'usb' category
>
> On Mon, Nov 16, 2020 at 03:04:52PM +0100, Philippe Mathieu-Daudé
> wrote:
> > On 11/15/20 7:48 PM, Gan Qixin wrote:
> > > The category of the u2f-passthru device is not set, put it into the 'usb'
> > > category.
> >
> > I guess we discussed this with Thomas 1 or 2 years ago but I don't
> > remember. I think it was about using set_bits() so devices can appear
> > in multiple categories.
> >
> > Gerd, do you know what is the point of the "usb" category for
> > management apps? This is a bus accepting multiple better categorized
> > devices (display, storage, input, network, sound).
>
> Right now we have the host adapters collected in the usb category.
> Maybe we should rename the category to make that clear.
>
> And, yes, tagging the u2f devices as "usb" doesn't look useful.
>
> > Unrelated but multiple devices are related to SECURITY.
> > Maybe it is time to introduce the DEVICE_CATEGORY_SECURITY?
>
> Either that, or place it in the "misc" category.
Thanks for your advice, I will put it into 'misc' category.
Gan Qixin
next prev parent reply other threads:[~2020-11-17 13:45 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-15 18:48 [PATCH 00/13] Categorize some uncategorized devices Gan Qixin
2020-11-15 18:48 ` [PATCH 01/13] pc-dimm: put it into the 'storage' category Gan Qixin
2020-11-15 18:48 ` [PATCH 02/13] virtio-pmem: " Gan Qixin
2020-11-19 14:12 ` Pankaj Gupta
2020-12-04 7:24 ` Pankaj Gupta
2020-11-15 18:48 ` [PATCH 03/13] vmmouse: put it into the 'input' category Gan Qixin
2020-11-16 14:05 ` Philippe Mathieu-Daudé
2020-11-15 18:48 ` [PATCH 04/13] nvdimm: put it into the 'storage' category Gan Qixin
2020-11-15 18:48 ` [PATCH 05/13] mc146818rtc: put it into the 'misc' category Gan Qixin
2020-11-15 18:48 ` [PATCH 06/13] ipmi: put some ipmi devices into the correct category Gan Qixin
2020-11-15 18:48 ` [PATCH 07/13] tpm: put some tpm " Gan Qixin
2020-11-15 18:48 ` [PATCH 08/13] AMDVI-PCI: put it into the 'misc' category Gan Qixin
2020-11-15 18:48 ` [PATCH 09/13] u2f-passthru: put it into the 'usb' category Gan Qixin
2020-11-16 14:04 ` Philippe Mathieu-Daudé
2020-11-17 6:58 ` Gerd Hoffmann
2020-11-17 13:40 ` ganqixin [this message]
2020-11-17 13:37 ` ganqixin
2020-12-04 13:50 ` Philippe Mathieu-Daudé
2020-12-07 8:05 ` ganqixin
2020-12-07 8:52 ` Thomas Huth
2020-11-15 18:49 ` [PATCH 10/13] tosa-ssp: put it into the 'misc' category Gan Qixin
2020-11-15 18:49 ` [PATCH 11/13] spitz: put some Spitz-family devices into the correct category Gan Qixin
2020-11-15 18:49 ` [PATCH 12/13] SPI flash devices: put them into the 'storage' category Gan Qixin
2020-11-16 13:59 ` Philippe Mathieu-Daudé
2020-11-16 16:19 ` Alistair Francis
2020-11-15 18:49 ` [PATCH 13/13] bcm2835_cprman: put some peripherals of bcm2835 cprman into the 'misc' category Gan Qixin
2020-11-16 13:25 ` Philippe Mathieu-Daudé
2020-11-16 13:31 ` Peter Maydell
2020-11-16 14:33 ` Thomas Huth
2020-11-16 14:30 ` Thomas Huth
2020-11-16 17:00 ` Markus Armbruster
2020-11-16 17:15 ` Peter Maydell
2020-11-17 5:41 ` Markus Armbruster
2020-11-17 11:08 ` Peter Maydell
2020-11-17 20:12 ` Thomas Huth
2020-11-18 8:41 ` Markus Armbruster
2020-11-18 8:50 ` Should bus-less devices default to .user_creatable = false? (was: [PATCH 13/13] bcm2835_cprman: put some peripherals of bcm2835 cprman into the 'misc' category) Markus Armbruster
2020-11-18 9:08 ` Thomas Huth
2020-11-17 14:02 ` [PATCH 13/13] bcm2835_cprman: put some peripherals of bcm2835 cprman into the 'misc' category ganqixin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A5B86EC83C48EF4CB2BC58BEF3A2F496065C37E3@DGGEMI525-MBS.china.huawei.com \
--to=ganqixin@huawei.com \
--cc=kraxel@redhat.com \
--cc=kuhn.chenqun@huawei.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=thuth@redhat.com \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.